Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.20.8 proposal #57631

Merged
merged 14 commits into from
Mar 27, 2025
Merged

v18.20.8 proposal #57631

merged 14 commits into from
Mar 27, 2025

Conversation

richardlau
Copy link
Member

2025-03-27, Version 18.20.8 'Hydrogen' (LTS), @richardlau

Notable Changes

This release updates OpenSSL to 3.0.16 and root certificates to NSS 3.108.

Commits

  • [f737a79073] - async_hooks,inspector: implement inspector api without async_wrap (Gabriel Bota) #51501
  • [fce923ba69] - build: update gcovr to 7.2 and codecov config (Benjamin E. Coe) #54019
  • [8b7ffd807c] - build: fix compatibility with V8's depot_tools (Richard Lau) #57330
  • [ee9a343413] - crypto: update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
  • [738bf8aea4] - crypto: update root certificates to NSS 3.104 (Richard Lau) #55681
  • [69d661d591] - deps: update undici to v5.29.0 (Matteo Collina) #57557
  • [59fcf43b0e] - deps: update corepack to 0.32.0 (Node.js GitHub Bot) #57265
  • [1b72869503] - deps: update archs files for openssl-3.0.16 (Node.js GitHub Bot) #57335
  • [a566560235] - deps: upgrade openssl sources to quictls/openssl-3.0.16 (Node.js GitHub Bot) #57335
  • [50c4e1da2f] - doc: add missing deprecated badges in fs.md (Yukihiro Hasegawa) #57384
  • [c3babb4671] - doc: update Xcode version used for arm64 and pkg (Michaël Zasso) #57104
  • [784da606a6] - doc: fix link and history of SourceMap sections (Antoine du Hamel) #57098
  • [f5dbceccbe] - test: update error code in tls-psk-circuit for for OpenSSL 3.4 (sebastianas) #56420

richardlau and others added 14 commits March 13, 2025 17:44
Recent changes to `depot_tools`'s `ninja.py` proxy is causing infinite
recursion in our V8 CI builds as we checkout `depot_tools` into a
directory with a leading `_` (i.e. `_depot_tools`) and the proxy now
checks for an exact match (i.e. `== "depot_tools"`) instead of
`endswith("depot_tools")`.

Rename our checkout to `depot_tools` (without the leading `_`) so the
`ninja.py` proxy can exclude it when reinvoking `ninja`.

PR-URL: #57330
Fixes: nodejs/build#4027
Refs: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6259139
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
Update parallel/test-tls-psk-circuit.js to account for error code
changes in OpenSSL 3.4 and probably later.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
PR-URL: #56420
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #57335
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57335
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This is the certdata.txt[0] from NSS 3.104.

This is the version of NSS that shipped in Firefox 131.0 on 2024-10-01.

Certificates added:
- FIRMAPROFESIONAL CA ROOT-A WEB
- TWCA CYBER Root CA
- SecureSign Root CA12
- SecureSign Root CA14
- SecureSign Root CA15

[0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_104_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: #55681
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
This is the certdata.txt[0] from NSS 3.108.

This is the version of NSS that shipped in Firefox 136.0 on 2025-03-04.

Certificates added:
- D-TRUST BR Root CA 2 2023
- D-TRUST EV Root CA 2 2023

Certificates removed:
- SwissSign Silver CA - G2

[0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_108_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: #57381
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #57265
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Implementing the inspector session object as an async resource causes
unwanted context change when a breakpoint callback function is being
called. Modelling the inspector api without the AsyncWrap base class
ensures that the callback has access to the AsyncLocalStorage instance
that is active in the affected user function.

See `test-inspector-async-context-brk.js` for an illustration of the
use case.

PR-URL: #51501
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #57098
Backport-PR-URL: #57131
Fixes: #57094
Refs: #48461
Refs: #47790
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #57104
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #57384
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #57557
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #54019
Backport-PR-URL: #57565
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Notable changes:

This release updates OpenSSL to 3.0.16 and root certificates to NSS 3.108.

PR-URL: #57631
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Mar 26, 2025
@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 4d0b4e7 into v18.x Mar 27, 2025
76 checks passed
richardlau added a commit that referenced this pull request Mar 27, 2025
@richardlau richardlau deleted the v18.20.8-proposal branch March 27, 2025 13:01
richardlau added a commit that referenced this pull request Mar 27, 2025
Notable changes:

This release updates OpenSSL to 3.0.16 and root certificates to NSS 3.108.

PR-URL: #57631
richardlau added a commit to nodejs/nodejs.org that referenced this pull request Mar 27, 2025
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Mar 27, 2025
* Blog: v18.20.8 release post

Refs: nodejs/node#57631

* fixup! Blog: v18.20.8 release post

Signed-off-by: Richard Lau <[email protected]>

---------

Signed-off-by: Richard Lau <[email protected]>
pandeykushagra51 pushed a commit to pandeykushagra51/node that referenced this pull request Mar 28, 2025
Notable changes:

This release updates OpenSSL to 3.0.16 and root certificates to NSS 3.108.

PR-URL: nodejs#57631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.