Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] accounting: credit note refund options removed in 17 #11957

Closed
wants to merge 1 commit into from
Closed

[IMP] accounting: credit note refund options removed in 17 #11957

wants to merge 1 commit into from

Conversation

afma-odoo
Copy link
Contributor

task-4376883

@robodoo
Copy link
Collaborator

robodoo commented Feb 4, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team February 4, 2025 14:48
dade-odoo
dade-odoo approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@dade-odoo dade-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor points, but nice work overall :)

@afma-odoo afma-odoo force-pushed the 17.0-accounting-credit-and-debit-notes-afma branch 2 times, most recently from 2e3e02c to e9c8562 Compare February 25, 2025 13:56
@afma-odoo afma-odoo requested a review from a team February 25, 2025 14:18
auva-odoo
auva-odoo requested changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @afma-odoo for your work! I added a few comments and suggestions in my review; let me know if you'd like to discuss anything.

Also, could we maybe add something in the "Issue a debit note" and "Record a debit note" headings (or in the introductory sentence) to avoid confusion between the two? What do you think?

@afma-odoo afma-odoo force-pushed the 17.0-accounting-credit-and-debit-notes-afma branch 3 times, most recently from e4c24fc to 33ee3bd Compare March 7, 2025 10:10
@C3POdoo C3POdoo requested a review from a team March 7, 2025 10:11
@afma-odoo
Copy link
Contributor Author

@auva-odoo Thank you for your suggestions, I updated the page accordingly ;) Just let me know if there's anything else I can improve!
For your info, I'll need to make some minor changes for 18.1.
Thank you!

@afma-odoo afma-odoo requested a review from auva-odoo March 7, 2025 10:24
@afma-odoo afma-odoo force-pushed the 17.0-accounting-credit-and-debit-notes-afma branch from 33ee3bd to 9f4db17 Compare March 11, 2025 09:13
auva-odoo
auva-odoo approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @afma-odoo, thank you for the changes!

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 11, 2025
@afma-odoo
[IMP] accounting: credit note refund options removed in 17
f6907ea 
task-4376883

closes #11957

Signed-off-by: Audrey Vandromme (auva) <[email protected]>
@robodoo robodoo closed this Mar 11, 2025
This was referenced Mar 11, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dade-odoo dade-odoo dade-odoo approved these changes

@auva-odoo auva-odoo auva-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afma-odoo @robodoo @dade-odoo @auva-odoo