Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Training - thsc #628

Open
wants to merge 20 commits into
base: 18.0
Choose a base branch
from

Conversation

ThomasSchneider-94
Copy link

No description provided.

@robodoo
Copy link

robodoo commented Mar 17, 2025

Pull request status dashboard

@ThomasSchneider-94 ThomasSchneider-94 force-pushed the 18.0-technical_training-thsc branch from 78c44db to 39fcd93 Compare March 17, 2025 16:30
Copy link

@dbeguin dbeguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ola ! a small review with some guidelines stuffs mainly.
Good work already !

README.md Outdated
@@ -9,5 +9,3 @@ tutorial's solutions, and one for the
[Master the Odoo web framework](https://www.odoo.com/documentation/latest/developer/tutorials/master_odoo_web_framework.html)
tutorial's solutions. For example, `17.0`, `17.0-discover-js-framework-solutions` and
`17.0-master-odoo-web-framework-solutions`.

Copy link

@dbeguin dbeguin Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can now fixup this commit with the first one (or even delete the 2 first commit as they are canceling each other :)

<field name="bedrooms"/>
<field name="living_area" string="Living Area (sqm)"/>
<field name="facades"/>
<filter string="Available Properties" name="available" domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also use this syntax :
domain="[('state', 'in', ['new', 'offer_received'])]"

@@ -0,0 +1,3 @@
{
"python.languageServer": "None"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add .vscode folder to your gitignore file

@ThomasSchneider-94 ThomasSchneider-94 force-pushed the 18.0-technical_training-thsc branch from 192cd2b to 12ca7f4 Compare March 20, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants