analyzer: Remove peerDependencies from NPM / Yarn test assets
#4665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
no-peer-deps
branch
from
e5a72c1 to
2eef5e2
Compare
sschuberth
changed the title
peerDependencies from NPM / Yarn test assets
sschuberth
force-pushed
the
no-peer-deps
branch
from
2eef5e2 to
e2945f7
Compare
fviernau
previously approved these changes
Nov 5, 2021
analyzer/src/funTest/assets/projects/synthetic/npm/no-lockfile/package.json
Show resolved
Hide resolved
ORT does not support `peerDependencies` yet [1]. That is mostly because handling of peer dependencies varies with NPM versions: Some versions do install them by default, some do not [2]. This results in ORT's functional tests to fail depending on the NPM version, and as it turns out, they would fail with the NPM version 7 currently used in ORT's `Dockerfile`. However, tests succeed on Azure CI which uses NPM 6. Avoid that inconsistency by simply not using peer dependencies at all for testing for now. [1]: #95 [2]: https://nodejs.org/en/blog/npm/peer-dependencies#using-peer-dependencies Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
no-peer-deps
branch
from
e2945f7 to
e19ba34
Compare
MarcelBochtler
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORT does not support
peerDependenciesyet 1. That is mostly becausehandling of peer dependencies varies with NPM versions: Some versions do
install them by default, some do not 2. This results in ORT's functional
tests to fail depending on the NPM version, and as it turns out, they
would fail with the NPM version 7 currently used in ORT's
Dockerfile.However, tests succeed on Azure CI which uses NPM 6. Avoid that
inconsistency by simply not using peer dependencies at all for testing for
now.
Signed-off-by: Sebastian Schuberth [email protected]