-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Inconsistencies in the CI tests #29685
Comments
how about slow incremental changes |
Absolutely, that makes a lot of sense. Are you ok with the general idea of the proposal, to move incrementally in that direction? |
Are you sure? I thpught we run them in the |
the pattern for that build is |
This is what we've got now:
|
Ahh gotcha. Looks like we only have 1 test with the mark |
Summarizing the work of the linked PRs that can close this issue
For further inconsistencies, let's open individual issues. |
Not sure if anyone know exactly what we are testing, but after removing Python 3.5 and some other old stuff, I think we've got lots of builds testing almost the same things, and the lack of a clear structure is preventing us from finding inconsistencies easily.
Some things that seem wrong:
network
marker in any build (we runnot slow and not network
andslow
)slow
in allowed failures (not sure if that's intentional)py36_locale_slow
is not actually running slow tests: https://github.com/pandas-dev/pandas/blob/master/ci/azure/posix.yml#L32To fix those, what I think it'd make more sense is:
azure-36-minimum_versions.yaml
, but including all dependencies, the current just got a small set). Test it in Linux (possibly in Windows and Mac if important, but I don't think so)Not sure I'm missing something, but I think this should make things much simpler, test more things, and we can even save couple of builds (we have 12 now)
CC: @jreback @TomAugspurger
The text was updated successfully, but these errors were encountered: