CI: Ensure all minimum optional dependencies are tested #45103
Conversation
mroeschke
force-pushed
the
ci/min_build
branch
from
58419df to
f703d55
Compare
jreback
added
CI
you updated the dev deps for this? cc @lithomas1 can you review |
Don't think so. lxml and openpyxl don't have pins in |
| @@ -289,7 +291,21 @@ def test_stata_options(fsspectest): | |||
|
|
|||
|
|
|||
| @td.skip_if_no("tabulate") | |||
| def test_markdown_options(fsspectest): | |||
| def test_markdown_options(request, fsspectest): | |||
There was a problem hiding this comment.
use @pytest.importorskip here with minversion?(pretty sure the issue here is with fsspec's min version only, but not sure).
There was a problem hiding this comment.
With @pytest.importorskip I think I would have to specify the min version + 1 to guarantee skipping the min version. I think the +1 aspect isn't as simple as adding +1 to whatever comes out of __version__
| - pip: | ||
| - py |
There was a problem hiding this comment.
Why add py? Also I'm pretty sure this is available on conda-forge. https://anaconda.org/conda-forge/py
There was a problem hiding this comment.
Ah cool I'll install the conda-forge version.
We have some tests that run on py.path objects
pandas/pandas/tests/io/test_common.py
Line 42 in cbefe18
Thought maybe in a follow up we should remove/discourage because it appears py.path is in maintenance only mode.
|
thanks @mroeschke @lithomas1 |
Progress towards #29685
actions-38-minimum_versions.yamlnow contains all optional dependencies with their min versionsactions-38-db.yaml->actions-38-downstream_compat.yamlactions-38-db-min.yamlremoved as redundant withactions-38-minimum_versions.yamlDiscoveries:
Min version of lxml and openpyxl with
.xlsmor.xlsxdoesn't seem to work. Need to bump to openpyxl to 3.0.9 https://openpyxl.readthedocs.io/en/stable/changes.html#id47