Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run xdist if pytest.mark.single_cpu #46014

Closed
wants to merge 10 commits into from

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Feb 16, 2022

Appears some of the single builds are still timing out. Checking if not activating xdist for this build does the trick

e.g. https://github.com/pandas-dev/pandas/runs/5206822069?check_suite_focus=true

EDIT: The timeouts are due to pyarrow engine in read_csv since mamba is installing pyarrow=2.0.0 (conda seems to install pyarrow=6.0.0 when unpinned)

@jreback jreback added this to the 1.5 milestone Feb 16, 2022
@jreback jreback added the Testing pandas testing functions or related to the test suite label Feb 16, 2022
@jreback jreback closed this Feb 16, 2022
@jreback jreback reopened this Feb 16, 2022
@jreback
Copy link
Contributor

jreback commented Feb 16, 2022

close/open a couple of times to make sure this doesn't affect

@jbrockmendel
Copy link
Member

@mroeschke can you comment on the status of the CI and/or your gameplan?

@mroeschke
Copy link
Member Author

My ideal CI Goals:

  1. Ensure we're testing PY3.8-10 on Linux/MacOS/Windows with all required + optional dependencies (min versions + unpinned)
    1a) Ensure all tests that are supposed to run are run
  2. Eliminate flaky behaviors (Have the red x represent an actual addressable failure)

Current CI Status:

  1. Testing PY3.8-10 on Linux/MacOS/Windows with required + optional dependencies (partial dependencies on MacOS)
    1a) Some tests are still not running that could be run
  2. Inching closer to eliminating flaky behaviors (it's usually always the optional dependencies s3/pyarrow)

TODO:

  1. Finish testing alignment: CI: Inconsistencies in the CI tests #29685
  2. Implement dependency conda-lock files to increase stability

@mroeschke mroeschke marked this pull request as draft February 18, 2022 03:34
@mroeschke
Copy link
Member Author

Closing in favor of #46059

@mroeschke mroeschke closed this Feb 19, 2022
@mroeschke mroeschke deleted the ci/single_followup branch March 7, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants