Skip to content

chore: alloy 0.14 #15635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 11, 2025
Merged

chore: alloy 0.14 #15635

merged 20 commits into from
Apr 11, 2025

Conversation

yash-atreya
Copy link
Contributor

@yash-atreya yash-atreya commented Apr 9, 2025 •
edited
Loading

Bumps

  • alloy 0.14

  • core 1.0

  • chains 0.2

  • eips 0.2

  • trie 0.8

  • op-allloy deps 0.13

  • revm 22

  • revm-inspectors 19

  • rand 0.9 (included in alloy-core 1.0)

  • secpk256k1 hasn't been updated to use rand 0.9. See: Update rand to 0.9.x rust-bitcoin/rust-secp256k1#788.
    To workaround this, rand_08 has also been included: 2550056

Workaround looks something like this:
#15635 (comment)

@yash-atreya
bumps:
73e3030 
- alloy 0.14
- core 1.0
- chains 0.2
- eips 0.2
- trie 0.8
@yash-atreya
flz 0.13
80a2941
@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Apr 9, 2025
@kevaundray kevaundray mentioned this pull request Apr 9, 2025
Merged
yash-atreya
yash-atreya commented Apr 9, 2025
View reviewed changes
crates/engine/invalid-block-hooks/src/witness.rs Outdated
state,
codes: Default::default(),
keys: state_preimages,
..Default::default()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prep for #15608

@mattsse mattsse marked this pull request as ready for review April 10, 2025 06:59
@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Apr 10, 2025
mattsse
mattsse approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pending @DaniPopes for sanity review

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Apr 10, 2025
@mattsse mattsse mentioned this pull request Apr 10, 2025
Draft
@mattsse
Copy link
Collaborator

mattsse commented Apr 10, 2025

failing compact test is unrelated because we renamed the type from PrimitiveSignature to just Signature

DaniPopes
DaniPopes requested changes Apr 10, 2025
View reviewed changes
DaniPopes
DaniPopes reviewed Apr 10, 2025
View reviewed changes
@yash-atreya yash-atreya requested a review from DaniPopes April 10, 2025 15:43
DaniPopes
DaniPopes approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Performance Report

Merging #15635 will improve performances by 10.13%

Comparing yash-atreya:yash/alloy-0.14 (9d26746) with main (c688c84)

Summary

⚡ 1 improvements
✅ 76 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ hash builder[init size 10000 | update size 100 | num updates 5] 47.2 ms 42.9 ms +10.13%

@mattsse mattsse merged commit 58fe204 into paradigmxyz:main Apr 11, 2025
41 of 43 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Apr 11, 2025
mattsse added a commit that referenced this pull request Apr 11, 2025
@mattsse
Revert "chore: alloy 0.14 (#15635)"
93cb15b 
This reverts commit 58fe204.
0xriazaka pushed a commit to 0xriazaka/reth that referenced this pull request Apr 13, 2025
@yash-atreya @mattsse @0xriazaka
chore: alloy 0.14 (paradigmxyz#15635)
cbad2bf 
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin left review comments

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yash-atreya @mattsse @shekhirin @DaniPopes