-
Notifications
You must be signed in to change notification settings - Fork 283
Update rand to 0.9.x #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rand to 0.9.x #788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a9fe576
You need to run update lock files from contrib directory. |
Done |
You also need to run the formatter and fix the compilation errors with the |
Also please squash the commits. |
Ok, i did:
|
I reverted rustfmt for the files which are not affected by the transition to rand v0.9.0. Only those touched by me are reformatted now. |
Seems like you are using the wrong version of the formatter. You need to use a nightly compiler to run |
Done |
Fixed the no-std test |
The wasm failure looks like it's related to a call to |
Ok. Let me know if there is anything more I can do for this PR. |
Ok, right now we depend on But I'm not sure what exactly to do here, but we should definitely get rid of the |
Ok, I've updated getrandom to 0.3. Somehow that required to update js-sys crate up to recent version 0.3.77. Sorry, I'm not a wasm guy, I've called contrib/wasm.sh and it ran with the following error when executing wasm-bindgen: Not sure what it means. Also I've updated rand_core dependency from 0.6 to 0.9. I've made a separate commit to simplify the review. If it looks good to you I can squash both commits into one. |
Can you squash? I think it's easiest to review this in one commit. |
Squashed |
Thanks for iterating so much! This looks great now. Nice to move to I will also run my local CI on this which will do a bunch more checks, and then we should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 993b4b7; successfully ran local tests
Closes #789