forked from angular/angular
-
Notifications
You must be signed in to change notification settings - Fork 1
aio circleci builds #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7c2f43
to
d41f6e3
Compare
c068ebd
to
a5a8942
Compare
149d4cc
to
6e9bc2b
Compare
1c1aa11
to
f1d81e8
Compare
docs: refactor style guide example 01-01 PR Close angular#22738
docs: fix instructions for switching directories PR Close angular#24439
Added argument type to filter function of rxjs. Fixed the return value of filtering of odd numbers PR Close angular#24947
When an Angular decorated class is inherited, it might be the case that the entire inheritance chain actually has no constructor defined. In that event, a factory which simply instantiates the type without any arguments should be used. PR Close angular#25425
) A small bug caused base factory variable statements for @component to not be emitted properly. At the same time as this is fixed, those statements are now emitted as const. PR Close angular#25425
…les_webtesting 0.2.1 (angular#25433) PR Close angular#25433
) Updating code snippet in docs that shows how to enable debug tools. PR Close angular#25361
Link to life-cycle hooks was spelt as "life-cycle hoooks". PR Close angular#25377
…ce worker (angular#25408) At the moment `cacheAge` can we undefined when having `Cache-Control` set to `no-cache` due the mapping method in `needToRevalidate` Closes angular#25442 PR Close angular#25408
8d311c1
to
3e8e167
Compare
a5813ca
to
fba0882
Compare
Now instead of pushing the AIO build artifacts to the preview server from inside a Travis job, the artifacts are built and hosted on the CircleCI infrastructure. The preview server will then pull these down after being triggered by a CircleCI build webhook.
…ircleCI Previously, Travis pushed the build artitfacts to the preview server. This required us to use JWT to secure the POST request from Travis, to ensure we couldn't receive malicious builds. JWT has been deprecated and we are moving our builds to CircleCI. This commit rewrites the TypeScript part of the preview server that handles converting build artifact into hosted previews of the docs.
The server no longer has files uploaded to it. Instead it is more accurate to refer to it as dealing with "previews" of PRs.
fba0882
to
92c8752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information