Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

remove ax argument from ROC constructor #255

Closed
edublancas opened this issue Jan 27, 2023 · 0 comments · Fixed by #261
Closed

remove ax argument from ROC constructor #255

edublancas opened this issue Jan 27, 2023 · 0 comments · Fixed by #261
Assignees

Comments

@edublancas
Copy link
Contributor

we found an issue in the docs (#231) that was patched by passing ax to the plot method of ROC (#250).

I just realized the ROC constructor also has an ax argument, which shouldn't be the case and we should remove it since ax should only be in the plot method.

I took a quick glance at the code and it looks like the ax in the constructor isn't doing anything so we can remove it. and I don't think people are using this argument so we can remove it silently (no need to deprecate it)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants