Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

remove ax from roc constructor #261

Merged
merged 8 commits into from
Jan 31, 2023

Conversation

gtduncan
Copy link
Contributor

@gtduncan gtduncan commented Jan 30, 2023

Describe your changes

Removes 'ax' parameter in ROC constructor method

Issue ticket number and link

Closes #255

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests (when necessary).
  • I have added the right documentation in the docstring and changelog (when needed)

📚 Documentation preview 📚: https://sklearn-evaluation--261.org.readthedocs.build/en/261/

@gtduncan gtduncan changed the title George remove ax roc constructor remove ax from roc constructor Jan 30, 2023
@coveralls
Copy link

coveralls commented Jan 30, 2023

Pull Request Test Coverage Report for Build 4050134927

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 94.028%

Totals Coverage Status
Change from base Build 4046788525: -0.002%
Covered Lines: 2850
Relevant Lines: 3031

💛 - Coveralls

@gtduncan gtduncan marked this pull request as ready for review January 30, 2023 21:01
Copy link
Contributor

@idomic idomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good besides the comment above.

@edublancas edublancas merged commit 22b206e into ploomber:master Jan 31, 2023
@coveralls
Copy link

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 4050134927

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.226%

Totals Coverage Status
Change from base Build 4046788525: 0.2%
Covered Lines: 2954
Relevant Lines: 3135

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ax argument from ROC constructor
4 participants