This repository was archived by the owner on Feb 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
remove ax from roc constructor #261
Merged
edublancas
merged 8 commits into
ploomber:master
from
gtduncan:george-remove-ax-roc-constructor
Jan 31, 2023
Merged
remove ax from roc constructor #261
edublancas
merged 8 commits into
ploomber:master
from
gtduncan:george-remove-ax-roc-constructor
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4050134927
💛 - Coveralls |
edublancas
suggested changes
Jan 30, 2023
idomic
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good besides the comment above.
changelog changelog specificity changelog fix changelog fix
…n/sklearn-evaluation into george-remove-ax-roc-constructor rebase
edublancas
approved these changes
Jan 31, 2023
Pull Request Test Coverage Report for Build 4050134927Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes 'ax' parameter in ROC constructor method
Issue ticket number and link
Closes #255
Checklist before requesting a review
📚 Documentation preview 📚: https://sklearn-evaluation--261.org.readthedocs.build/en/261/