fixed error in roc.py causing blank plots #250
Conversation
gtduncan
changed the title
Pull Request Test Coverage Report for Build 4028181701
💛 - Coveralls |
rerunning docs docs rerun
* test * pinning scikit-learn * replaces papermill with ploomber-engine docs update docs update
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| - [API Change] A new figure and axes is created (via `plt.subplots()`) when calling a plotting method with `ax=None`. Previously, the current axes was used (via `plt.gca()`) ([#211](https://github.com/ploomber/sklearn-evaluation/pull/211)) | |||
| - [Fix] Validating input elbow curve model has "score" method [#146] | |||
| - [Fix] Adds class labels for multi class roc plot (#209) | |||
| - [Fix] Fixed error in which ROC curves would not graph on subplots | |||
There was a problem hiding this comment.
This should be [Docs], the text should probably be, Fixed ROC curves plots to show properly.
There was a problem hiding this comment.
This is an interesting one because the flaw was discovered in the docs, but the actual fix is in the source code. 🤔
There was a problem hiding this comment.
Yeah, maybe we can call it a fix after all. @gtduncan
There was a problem hiding this comment.
So if it fits both categories, we should probably take the code first approach.
There was a problem hiding this comment.
Something weird is happening here as well, the tests are running for 3 hours already.
There was a problem hiding this comment.
That's what I was about to ask about, but it seems to be happening to the CI checks for all the PRs today
There was a problem hiding this comment.
I ran all the tests locally and they passed
There was a problem hiding this comment.
Stay tuned, work on other issues :)
There was a problem hiding this comment.
the error has been fixed, please rebase
Updating docs dependencies to ploomber-engine (ploomber#252) * test * pinning scikit-learn * replaces papermill with ploomber-engine merge changelog corrected
|
Nice job @gtduncan ! |
Describe your changes
Found error in roc.py in which a call to plot() was missing a parameter. ROC curves should now be able to be graphed on subplots instead of separately from a blank plot, seen here
Issue ticket number and link
Closes #231
Checklist before requesting a review
📚 Documentation preview 📚: https://sklearn-evaluation--250.org.readthedocs.build/en/250/