(maint) Add missing dependency on clojure.set #77
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaggett
reviewed
Jul 11, 2022
| @@ -1,6 +1,7 @@ | |||
| (ns puppetlabs.trapperkeeper.services.metrics.metrics-testutils | |||
| (:import (com.codahale.metrics.graphite GraphiteSender)) | |||
| (:require [schema.core :as schema])) | |||
| (:require [schema.core :as schema] | |||
| [clojure.set])) | |||
There was a problem hiding this comment.
I think it would be good to do
Suggested change
| [clojure.set])) | |
| [clojure.set :as set])) |
and then update the use of clojure.set/union to set/union. That is the pattern we tend to follow in other repos.
There was a problem hiding this comment.
There's no hurry, until the next release we can carry a patch in the package without issue. Thanks!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the testsuite in a Debian build environment.