Skip to content

(maint) Add missing dependency on clojure.set #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(maint) Add missing dependency on clojure.set #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/puppetlabs/trapperkeeper/services/metrics/metrics_testutils.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
(ns puppetlabs.trapperkeeper.services.metrics.metrics-testutils
(:import (com.codahale.metrics.graphite GraphiteSender))
(:require [schema.core :as schema]))
(:require [schema.core :as schema]
[clojure.set]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to do

Suggested change
[clojure.set]))
[clojure.set :as set]))

and then update the use of clojure.set/union to set/union. That is the pattern we tend to follow in other repos.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no hurry, until the next release we can carry a patch in the package without issue. Thanks!


(def graphite-config
{:graphite
Expand Down