feat: add publisher caps to the validator #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregation errors
…ges until v1 buffer is cleared
guibescos
changed the title
ali-bahjati
reviewed
Jul 24, 2024
Riateche
requested changes
Jul 24, 2024
Co-authored-by: Pavel Strakhov <[email protected]>
Co-authored-by: Pavel Strakhov <[email protected]>
keyvankhademi
previously approved these changes
Jul 30, 2024
Riateche
previously requested changes
Jul 31, 2024
ali-bahjati
reviewed
Jul 31, 2024
| for account in account_datas { | ||
| if let Some(price_account) = checked_load_price_account(account) { | ||
| let cap: u64 = m | ||
| .checked_div(max(u64::from(price_account.num_), z)) |
There was a problem hiding this comment.
side-note: it's good to update our formula in the doc to mention we take the floor of the division when we sum it up.
There was a problem hiding this comment.
In practice it will be a very small difference since $PYTH has 6 decimals, so n_symbols * 10^-6
ali-bahjati
reviewed
Jul 31, 2024
ali-bahjati
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implements the publisher cap as:
where M and Z are parameters, n_s is the number of publishers of symbol s