feat: add publisher caps to the validator #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guibescos
force-pushed
the
feat/publisher-caps
branch
from
4b69572 to
ef0ad5a
Compare
guibescos
force-pushed
the
feat/publisher-caps
branch
from
386678b to
aab935e
Compare
OpenCoreCH
reviewed
Jul 29, 2024
| parameters.z, | ||
| ); | ||
|
|
||
| if bank |
There was a problem hiding this comment.
Small detail: Checking this at the beginning and exiting early if the feature set is deactivated would avoid some unnecessary computations if it is deactivated.
There was a problem hiding this comment.
It can be useful so that we detect errors in the logic before the feature activation or before a majority of nodes have updated.
guibescos
commented
Jul 30, 2024
keyvankhademi
approved these changes
Jul 30, 2024
Riateche
approved these changes
Jul 31, 2024
ali-bahjati
reviewed
Jul 31, 2024
runtime/Cargo.toml
Outdated
| @@ -35,8 +35,8 @@ num-traits = { version = "0.2" } | |||
| num_cpus = "1.13.1" | |||
| once_cell = "1.12.0" | |||
| ouroboros = "0.15.0" | |||
| pyth-oracle = { git = "https://github.com/pyth-network/pyth-client", tag = "oracle-v2.32.1", features = ["library"] } | |||
| pythnet-sdk = { git = "https://github.com/pyth-network/pyth-crosschain", version = "1.13.6", rev = "e670f57f89b05398ca352e4accb1e32724a8e1b4" } | |||
| pyth-oracle = { git = "https://github.com/pyth-network/pyth-client.git" ,branch="feat/publisher-caps" , features = ["library"] } | |||
There was a problem hiding this comment.
let's change it once it's merged.
ali-bahjati
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computes the
PublisherStakeCapsMessageno matter what, and adds it to the accumulator Merkle tree if the feature flag is turned on. The idea is that if there are any bugs they should be caught when each individual validator upgrades and not when the flag is turned on.The computation is performed by pyth-network/pyth-client#412