Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(deprecated) Docstring 수정 #56

Closed
wants to merge 15 commits into from
Closed

(deprecated) Docstring 수정 #56

wants to merge 15 commits into from

Conversation

heehehe
Copy link
Member

@heehehe heehehe commented Aug 20, 2023

각자 작업하신 것 여기 docs/improve-comments 브랜치에 올려주시고 여기 PR에서 서로 리뷰하면 좋을 것 같습니다 :)

Resolve #43

  • PEP8 따르는 주석으로 수정

syeeuns and others added 15 commits August 2, 2023 12:00
@syeeuns @ebang091
Add MariadbBinLogCheckPointEvent
d83498b
@yangbaechu @ebang091
Add a test for MariadbBinLogCheckPointEvent
d62ce82
@jaehyeonpy @ebang091
improve readability and dump() to satisfy its requirements better, pr…
db6ba2b 
…event memory leak in MariadbBinLogCheckPointEvent
@jaehyeonpy @ebang091
fix database port setting error in PyMySQLReplicationMariaDbTestCase
a21eaef
@syeeuns @ebang091
fix : docker-compose.yaml for mariadb, test_binlog_checkpoint_event, …
de23865 
…MariadbBinLogCheckPointEvent annotation
@jaehyeonpy
fix docker-compose.yml typo error, test_binlog_checkpoint_event compl…
733db4f 
…etely
@ebang091
fix annotation following PEP8 (PEP 257)
30b0152
@ebang091
fix : Annotation for autoModule Docstring
af39ab8
@ebang091
docs: MariadbBinLogCheckPointEvent comments
423477d
@ebang091
docs: MariadbGtidEvent
f0ff26d
@ebang091
docs: RotateEvent, XAPrepareEvent, XidEvent
6e58daa
@ebang091
docs: HeartBeatEvent, add Description part
2b520e9
@ebang091
docs: GtidEvent, remove Description Part
c18449c
@starcat37
docs: NotImplementedEvent, add Description Part
1675e69
@starcat37
docs: IntvarEvent
1f14fbc
heehehe
heehehe commented Aug 20, 2023
View reviewed changes
docker-compose.yml
Comment on lines +19 to +30
mariadb-10.6:
image: mariadb:10.6
environment:
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: 1
ports:
- "3308:3306"
command: |
--server-id=1
--default-authentication-plugin=mysql_native_password
--log-bin=master-bin
--binlog-format=row
--log-slave-updates=on
Copy link
Member Author

@heehehe heehehe Aug 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞에 다른 커밋들로 인해 다른 작업이 여기 브랜치에 섞여 들어간 것 같아서 제외가 필요해보입니다 👀
(아니면 여기 커밋 내용 그대로 upstream에 반영될거 고려해서 새로운 브랜치 만들어서 다시 작업해도 괜찮을 것 같구요..!)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러네요..! 제가 branch를 처음에 잘못 팠나봅니다.. 죄송합니다
브랜치 새롭게 만들어서 다시 작업하는 것도 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 아니에요 괜찮습니다!! 브랜치가 매번 여러 작업 하다보면 꼬이기 쉬운 것 같아요🥲

#58 여기에 새로운 브랜치 만들어둬서 작업하신 내용 이쪽으로 다시 추가해주시면 되겠습니다!
여기 PR은 close 시킬게요 :)

@heehehe heehehe mentioned this pull request Aug 20, 2023
Closed
@heehehe heehehe changed the title Docstring 수정 (deprecated) Docstring 수정 Aug 20, 2023
@heehehe heehehe closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebang091 ebang091 ebang091 left review comments

Assignees

@heehehe heehehe

@mjs1995 mjs1995

@chungeun-choi chungeun-choi

@starcat37 starcat37

@mikaniz mikaniz

@ebang091 ebang091

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstring 수정
9 participants
@heehehe @ebang091 @mjs1995 @chungeun-choi @starcat37 @mikaniz @syeeuns @yangbaechu @jaehyeonpy