forked from julien-duponchelle/python-mysql-replication
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(deprecated) Docstring 수정 #56
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d83498b
Add MariadbBinLogCheckPointEvent
syeeuns d62ce82
Add a test for MariadbBinLogCheckPointEvent
yangbaechu db6ba2b
improve readability and dump() to satisfy its requirements better, pr…
jaehyeonpy a21eaef
fix database port setting error in PyMySQLReplicationMariaDbTestCase
jaehyeonpy de23865
fix : docker-compose.yaml for mariadb, test_binlog_checkpoint_event, …
syeeuns 733db4f
fix docker-compose.yml typo error, test_binlog_checkpoint_event compl…
jaehyeonpy 30b0152
fix annotation following PEP8 (PEP 257)
ebang091 af39ab8
fix : Annotation for autoModule Docstring
ebang091 423477d
docs: MariadbBinLogCheckPointEvent comments
ebang091 f0ff26d
docs: MariadbGtidEvent
ebang091 6e58daa
docs: RotateEvent, XAPrepareEvent, XidEvent
ebang091 2b520e9
docs: HeartBeatEvent, add Description part
ebang091 c18449c
docs: GtidEvent, remove Description Part
ebang091 1675e69
docs: NotImplementedEvent, add Description Part
starcat37 1f14fbc
docs: IntvarEvent
starcat37 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앞에 다른 커밋들로 인해 다른 작업이 여기 브랜치에 섞여 들어간 것 같아서 제외가 필요해보입니다 👀
(아니면 여기 커밋 내용 그대로 upstream에 반영될거 고려해서 새로운 브랜치 만들어서 다시 작업해도 괜찮을 것 같구요..!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그러네요..! 제가 branch를 처음에 잘못 팠나봅니다.. 죄송합니다
브랜치 새롭게 만들어서 다시 작업하는 것도 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 아니에요 괜찮습니다!! 브랜치가 매번 여러 작업 하다보면 꼬이기 쉬운 것 같아요🥲
#58 여기에 새로운 브랜치 만들어둬서 작업하신 내용 이쪽으로 다시 추가해주시면 되겠습니다!
여기 PR은 close 시킬게요 :)