Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Newline at end of NEWS entry #256

Closed
sweeneyde opened this issue Feb 10, 2022 · 5 comments · Fixed by #257
Closed

Include Newline at end of NEWS entry #256

sweeneyde opened this issue Feb 10, 2022 · 5 comments · Fixed by #257

Comments

@sweeneyde
Copy link
Member

The NEWS entry added by blurb-it does not contain a newline at the end of the file, which makes the Docs CI check fail since the addition of sphinx-lint in python/cpython#31097

See python/cpython#31266 :

Error: [1] ../Misc/NEWS.d/next/Documentation/2022-02-10-23-40-54.bpo-44953.ZvrfXw.rst:0: No newline at end of file (no-newline-at-end-of-file).
@Mariatta
Copy link
Member

I think this should take care of it: #257

Mariatta added a commit that referenced this issue Feb 11, 2022
@sweeneyde
Copy link
Member Author

Thanks for the very fast turn-around time!

@Mariatta
Copy link
Member

Thanks you for the report and the review! The change has been deployed. Please try.

@sweeneyde
Copy link
Member Author

It worked! The Docs CI passed the "Check documentation" step, and the Azure Pipelinze CI passed its "Build Docs" step.

@vstinner
Copy link
Member

That was quick, thanks @Mariatta! Thanks to your nice service, a contributor was able to easily add a NEWS entry to his PR: python/cpython#29693 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants