bpo-46643: Fix stringized P.args/P.kwargs with get_type_hints #31238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Feb 10, 2022
|
We should be able to move forward with this now re: https://mail.python.org/archives/list/[email protected]/thread/WZ4BCFO4VZ7U4CZ4FSDQNFAKPG2KOGCL/ |
GBeauregard
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
JelleZijlstra
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Thanks! @gvanrossum planning to merge this small typing change.
|
Thanks @GBeauregard for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-31646 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 3, 2022
…GH-31238) (cherry picked from commit 75d2d94) Co-authored-by: Gregory Beauregard <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 3, 2022
(cherry picked from commit 75d2d94) Co-authored-by: Gregory Beauregard <[email protected]>
|
Blurb-it was fixed at python/blurb_it#256. |
|
Oops, I can fix it in a few hours.
…On Wed, Mar 2, 2022 at 6:27 PM Dennis Sweeney ***@***.***> wrote:
sphinx-lint was added after the most recent CI job ran on this PR, so it
looks like we need to add a newline at the end of the NEWS entry to fix
Azure Pipelines PR.
Blurb-it was fixed at python/blurb_it#256
<python/blurb_it#256>.
—
Reply to this email directly, view it on GitHub
<#31238 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG5K2F5GGADFAD3H5TTUDLU6APRHANCNFSM5N627C3A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Fix in #31651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's discussion since fixing this also allows using
P.argsandP.kwargsinsidetyping.Annotated. See the bpo issue. We should wait for that discussion to resolve first.https://bugs.python.org/issue46643