-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compiler category in left nav #3184
base: main
Are you sure you want to change the base?
Conversation
svekars
commented
Dec 12, 2024
- Add a Compiler category in left nav and torch.compile tutorials there
- Ad Compiler tag to relevant tutorials
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3184
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7c83408 with merge base 1437a21 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
@@ -584,7 +584,7 @@ Welcome to PyTorch Tutorials | |||
:card_description: Train BERT, prune it to be 2:4 sparse, and then accelerate it to achieve 2x inference speedups with semi-structured sparsity and torch.compile. | |||
:image: _static/img/thumbnails/cropped/Pruning-Tutorial.png | |||
:link: advanced/semi_structured_sparse.html | |||
:tags: Text,Model-Optimization | |||
:tags: Text,Model-Optimization,Compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a torch.compile tutorial. It uses torch.compile, but it's more of a Model Optimization (sparsity) thing
intermediate/torch_compile_tutorial | ||
intermediate/compiled_autograd_tutorial | ||
intermediate/transformer_building_blocks | ||
intermediate/inductor_debug_cpu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the following while you're at it?
https://pytorch.org/tutorials/intermediate/torch_compile_tutorial.html
https://pytorch.org/tutorials/intermediate/compiled_autograd_tutorial.html
https://pytorch.org/tutorials/intermediate/inductor_debug_cpu.html
https://pytorch.org/tutorials/recipes/torch_compiler_set_stance_tutorial.html
https://pytorch.org/tutorials/recipes/torch_export_challenges_solutions.html
https://pytorch.org/tutorials/recipes/compiling_optimizer.html
https://pytorch.org/tutorials/recipes/compiling_optimizer_lr_scheduler.html
https://pytorch.org/tutorials/recipes/torch_compile_user_defined_triton_kernel_tutorial.html
https://pytorch.org/tutorials/recipes/torch_compile_caching_tutorial.html
https://pytorch.org/tutorials/recipes/regional_compilation.html
|
||
intermediate/torch_compile_tutorial | ||
intermediate/compiled_autograd_tutorial | ||
intermediate/transformer_building_blocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a torch.compile tutorial (https://pytorch.org/tutorials/intermediate/transformer_building_blocks.html). It uses torch.compile, but it is more about optimizing transformers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a distinction between "tutorial that uses torch.compile" vs "tutorial on how to use torch.compile". Tutorials that fall into the latter category should be grouped together