Order by selected items when using distinct exists #735
+44
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing "FinderTest#test_exists_with_distinct_and_offset_and_select" test.
See failing test at https://travis-ci.org/rails-sqlserver/activerecord-sqlserver-adapter/jobs/655397653?utm_medium=notification&utm_source=github_status
The issue was introduced by rails/rails#36647
The issue was caused by ordering being removed for distinct exists queries. This is fine for other adapters but MSSQL requires ordering on the items in the select distinct.
The failing test produced the following invalid MSSQL SQL:
This PR produces: