Fix relation.exists? with giving distinct, offset and order for joined table
#36647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or joined table The error happens in PostgreSQL when using `relation.exists?` with `distinct`, `offset` and `order` for joined table. However, the error does not happen if either `distinct` or `offset` is removed. This behavior is confusing. Fixes #36632
kamipo
added a commit
that referenced
this pull request
Jul 11, 2019
…_offset_and_order_in_postgresql Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table
kamipo
added a commit
that referenced
this pull request
Jul 11, 2019
…_offset_and_order_in_postgresql Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table
kamipo
added a commit
that referenced
this pull request
Jul 11, 2019
…_offset_and_order_in_postgresql Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table
giraffate
deleted the
fix_exists_with_distinct_and_offset_and_order_in_postgresql
branch
JesseChavez
pushed a commit
to JesseChavez/rails
that referenced
this pull request
Dec 19, 2019
…t_and_offset_and_order_in_postgresql Fix `relation.exists?` with giving `distinct`, `offset` and `order` for joined table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
relation.exists?with givingdistinct,offsetandorderfor joined tableThe error happens in PostgreSQL when using
relation.exists?withdistinct,offsetandorderfor joined table.However, the error does not happen if either
distinctoroffsetisremoved. This behavior is confusing.
Fixes #36632