-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Investigate Narwhals tests failures when run with cudf.pandas #18248
Comments
Skips the tests for now so that nightly CI passes. We need to investigate the tests we skip to see which ones can be fixed. Tracking Issue for that work is in #18248 Authors: - Matthew Murray (https://github.com/Matt711) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) URL: #18249
I'm investigating the cross join test failures. |
#18255 will help partially resolve the skipped since |
|
|
They are testing a Narwhals implementation of |
Describe the bug
In #18031, we started running the Narwhals test suite with cudf.pandas. There are several failing tests that we needed to skip (listed in https://github.com/rapidsai/cudf/blob/branch-25.04/ci/test_narwhals.sh). We should either fix these failures or explain why they won't be fixed.
Steps/Code to reproduce bug
Follow the steps in this shell scripts (eg. clone Narwhals, install dependencies, etc.).
Additional context
Please xref this issue once you've fixed a test
Original Issue to add Narwhals tests to cuDF: #17662
The text was updated successfully, but these errors were encountered: