Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overly Spammy Log Message #1

Open
isugimpy opened this issue Apr 6, 2021 · 2 comments
Open

Overly Spammy Log Message #1

isugimpy opened this issue Apr 6, 2021 · 2 comments

Comments

@isugimpy
Copy link
Contributor

isugimpy commented Apr 6, 2021

experiments.py/reddit_experiments/__init__.py

Line 135 in c5f8373

logger.info("Experiment <%r> not found in experiment config", name)
This log line has the potential to be extremely verbose. Could we potentially rate limit logging on it, either by time window or just have it display once the first time it's seen in a given process run for each experiment ID? Discovered this by accident in an older version of Baseplate before it was spun out.
@isugimpy
Copy link
Contributor Author

@spladug Not sure who else I should tag here, but this causes abusive levels of log volume.

@curioussavage
Copy link

I have this logger set to warning in our services: https://github.snooguts.net/reddit/reddit-service-post/blob/864db521a8186731a1e9801c3b3507c84d825d75/post/__init__.py#L468

@isugimpy isugimpy mentioned this issue May 17, 2021
Merged
mrlevitas pushed a commit that referenced this issue Apr 12, 2022
@mattknox
add fields to Feature so that we can have holdouts and experiment gro…
b572120 
…ups (#1)

* add fields for holdout and mutex

* change from strings to feature_groups, fixups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@curioussavage @isugimpy