Convert experiment not found log to a warning #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spladug
suggested changes
May 17, 2021
reddit_experiments/__init__.py
Outdated
| @@ -23,6 +24,7 @@ | |||
|
|
|||
|
|
|||
| logger = logging.getLogger(__name__) | |||
| logging.captureWarnings(True) | |||
There was a problem hiding this comment.
This is done by baseplate-serve: https://github.com/reddit/baseplate.py/blob/develop/baseplate/server/__init__.py#L114
Generally, we shouldn't be setting global logging configuration from libraries -- applications should be the ones doing that. (baseplate-serve being an application though it's in the codebase of a library!)
reddit_experiments/__init__.py
Outdated
| @@ -132,7 +134,7 @@ def _get_experiment(self, name: str) -> Optional[Experiment]: | |||
| self._cfg_data = self._get_config() | |||
|
|
|||
| if name not in self._cfg_data: | |||
| logger.info("Experiment <%r> not found in experiment config", name) | |||
| warnings.warn(f"Experiment <{repr(name)}> not found in experiment config", RuntimeWarning) | |||
There was a problem hiding this comment.
The docs say RuntimeWarning is "Base category for warnings about dubious runtime features." I think that sounds like it should be for interpreter-level stuff, not our use. It'd probably be fine to leave this un-specified (which defaults toUserWarning) or subclass our own ExperimentsWarning if we really want to be fancy.
spladug
approved these changes
May 17, 2021
Merged
mrlevitas
pushed a commit
that referenced
this pull request
Apr 12, 2022
* holeeeeshititworks * Cargo fixes * added comment breadcrumb trail
This was referenced Dec 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should alleviate the problem in #1, I believe.