Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel loose all #115

Closed
dariocravero opened this issue Jun 16, 2015 · 7 comments
Closed

babel loose all #115

dariocravero opened this issue Jun 16, 2015 · 7 comments

Comments

@dariocravero
Copy link
Contributor

@acdlite flummox is using "loose": "all" in .babelrc. Babel says that we would have some speed gains from using it but that it might be risky. What are your thoughts/experience with it in flummox so far? Should we include that into redux as well?
@acdlite
Copy link
Collaborator

acdlite commented Jun 16, 2015

It's for IE8 support.

@acdlite
Copy link
Collaborator

acdlite commented Jun 16, 2015

As long as we're careful to avoid the edge cases, I'm 👍 for using loose mode.

@chicoxyzzy
Copy link
Contributor

loose mode FTW

@gaearon
Copy link
Contributor

gaearon commented Jun 16, 2015

I'm OK if we're not breaking anything

@dariocravero
Copy link
Contributor Author

:) good stuff.
I'll bring it in as part as #88 if you're ok with it then as I've just finished putting together a browser version of the library like flummox has (kindly borrowing its scripts for webpack as I was always using browserify so far).

dariocravero pushed a commit to dariocravero/redux that referenced this issue Jun 16, 2015
Removed babel-runtime from the dependencies and brought in a dist
0a434a7 
script (reusing flummox's one) so that we can output a dist-ready
version of it.

Fixes reduxjs#115. Fixes reduxjs#88.
@dariocravero dariocravero mentioned this issue Jun 17, 2015
Closed
@ooflorent
Copy link
Contributor

Previous version of Babel hadn't decorators support in loose mode.
It seems to be fixed. 👍

@dariocravero dariocravero mentioned this issue Jun 18, 2015
Closed
@ooflorent
Copy link
Contributor

Fixed in dd83188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ooflorent @dariocravero @gaearon @chicoxyzzy @acdlite