Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit dependencies and add browser ready builds #142

Closed
wants to merge 1 commit into from

Conversation

dariocravero
Copy link
Contributor

Added:

  • Dist build script (borrowed from flummox) to create distribution ready builds of redux
    that can be used in a browser directly. dist/ is ignored by git.
  • Configuration for cdnjs autoimport from npm.

Changed:

  • Clean up package.json by removing the unused browserify section;
  • Remove envify and babel-runtime as they aren't being used;
  • A change log :)

Fixes #112, Fixes #115. Fixes #88.

- Dist build script (borrowed from flummox) to create distribution ready builds of redux
  that can be used in a browser directly. `dist/` is ignored by git.
- Configuration for `cdnjs` autoimport from npm.

> Changed
- Clean up package.json by removing the unused browserify section;
- Remove envify and babel-runtime as they aren't being used;
- A change log :)
@dariocravero
Copy link
Contributor Author

@ooflorent could you double check that the cdnjs stuff is right? :)
@gaearon as I was saying on slack, I don't know if there's any difference with the compiled react and react-native version as both expect a global called React. Perhaps we can get rid of one of them afterwards? Maybe it's a good idea to keep them should the need to be different? Thoughts?

The uglified and gzipped version of the whole thing is at around 3kb (core (~1kb) + react (~2kb)). AMAZING :). Well done everyone for keeping redux so lean! :)

@dariocravero
Copy link
Contributor Author

@gaearon I think you have to import it to cdnjs?

@@ -0,0 +1,16 @@
# Change Log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to fill this from Releases page?

@gaearon
Copy link
Contributor

gaearon commented Jun 19, 2015

Merged via dd83188.

@gaearon gaearon closed this Jun 19, 2015
@gaearon
Copy link
Contributor

gaearon commented Jun 19, 2015

I slightly changed it: now react-redux exports everything there is. I don't think it makes sense to separate them. (And with the config in this PR, they exported to the same global which wouldn't work anyway.) It's like “with addons” vs “without addons” now.

@dariocravero
Copy link
Contributor Author

Brilliant! :) Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants