Rollup of 6 pull requests #100082
Merged
Rollup of 6 pull requests #100082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lnicola Find standalone proc-macro-srv on windows too I forgot that executables end with `.exe` on Windows in: * rust-lang/rust-analyzer#12858
fix: Fix server panicking on project loading when proc-macros are disabled Fixes rust-lang/rust-analyzer#12879
fix: Insert spaces when inlining a function defined in a macro. (partially) fixes rust-lang#12860. This PR (only) addresses the whitespace issue when inlining functions defined in macros. Additionally, the indentation/spacing is not ideal, but works, e.g. ```rs macro_rules! define_function { () => { fn test_function_macro() { if let Some(3) = 3i32.checked_add(0) { println!("3 + 0 == 3"); } } }; } define_function!(); fn main() { test_function_macro(); } // previously became // ... fn main() { ifletSome(3)=3i32.checked_add(0){println!("3 + 0 == 3");}; } // now becomes // ... fn main() { if let Some(3) = 3i32.checked_add(0){ println!("3 + 0 == 3"); }; } ``` The `self` -> `this` problem[^this] is (probably?) a separate problem that I am also looking into. [^this]: As mentioned in [my comment on the above issue](rust-lang/rust-analyzer#12860 (comment)), inlining a method defined in a macro does not properly replace `self` with the new local `this`.
fix: Fix Semantics::original_ast_node not caching the resulting file
fix: Honor ref expressions for compute_ref_match completions Fixes rust-lang/rust-analyzer#8357
Signed-off-by: hi-rustin <[email protected]>
…x, r=Veykril Find original ast node before compute ref match ref rust-lang/rust-analyzer#12717
internal: Assume condition/iterable is missing if there is only a BlockExpr cc rust-lang/rust-analyzer#12880 (comment) It sounds good on paper, so let's try it
Use large stack on expander thread I have verified that this fixes rust-lang#12884 for me. Hat tip to `@bjorn3` for identifying the cause of the issue.
fix: Calculate completions after type anchors Fixes rust-lang/rust-analyzer#12892
fix: Fix pattern completions adding unnecessary braces Fixes rust-lang/rust-analyzer#12852
fix: Do completions in path qualifier position Fixes rust-lang/rust-analyzer#12566 Not too happy with the duplication needed for this, but it is what it is. Completions in path qualifiers will have to be filtered properly still, but its better to show too many completions for this than too few for now.
publish: Use cargo ws rename to rename crates Follow up for rust-lang#12716
fix: Don't complete marker traits in expression position cc rust-lang/rust-analyzer#12196
fix: Order ItemScope::entries results
…-Simulacrum parallelize HTML checking tool there's a lot of IO, so timings on my laptop are far from stable, but it seems to be considerably faster. this step often appears to take 5+ minutes in CI, so hopefully this offers a speedup
…-errors
Improve position named arguments lint underline and formatting names
For named arguments used as implicit position arguments, underline both
the opening curly brace and either:
* if there is formatting, the next character (which will either be the
closing curl brace or the `:` denoting the start of formatting args)
* if there is no formatting, the entire arg span (important if there is
whitespace like `{ }`)
This should make it more obvious where the named argument should be.
Additionally, in the lint message, emit the formatting argument names
without a dollar sign to avoid potentially confusion.
Fixes rust-lang#99907
Update all pre-cloned submodules on startup Fixes rust-lang#99083
…r=lnicola ⬆️ rust-analyzer r? `@ghost`
Clarify Cargo.toml comments Existing comments were left in an incoherent state after rust-lang#99768. r? `@RalfJung`
rustc-docs: Be less specific about the representation of `+bundle` For rust-lang#99429. r? `@bjorn3`
rustbot
added
T-bootstrap
|
@bors r+ rollup=never p=10 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e20f7f8 with merge acd0db76d6536fd56f8cf35a79be1659fe74d472... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (e141246): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
+bundle#100074 (rustc-docs: Be less specific about the representation of+bundle)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup