Improve position named arguments lint underline and formatting names #99958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@lqd This addresses your comment here: #99660 (comment) Not sure if you want to be the reviewer here or not though? |
|
r? @compiler-errors since i reviewed the other two PRs touching this code |
| @@ -190,7 +190,7 @@ LL | "{}, Hello {1:2$.3$} {4:5$.6$}! {1}", | |||
| | - this formatting argument uses named argument `f` by position | |||
| ... | |||
| LL | f = 0.02f32, | |||
| | ^ this named argument is only referred to by position in formatting string | |||
There was a problem hiding this comment.
Did you mean to drop "only" here?
There was a problem hiding this comment.
With the previous PR, the lint will trigger for every case a named argument is used positionally even if it's used by name elsewhere, so I think "only" is now incorrect. (I missed this in the last change.)
For named arguments used as implicit position arguments, underline both
the opening curly brace and either:
* if there is formatting, the next character (which will either be the
closing curl brace or the `:` denoting the start of formatting args)
* if there is no formatting, the entire arg span (important if there is
whitespace like `{ }`)
This should make it more obvious where the named argument should be.
Additionally, in the lint message, emit the formatting argument names
without a dollar sign to avoid potentially confusion.
Fixes rust-lang#99907
PrestonFrom
force-pushed
the
issue_99907
branch
from
d0ebef7 to
298acef
Compare
|
@compiler-errors Thank you for the review! It looks like #99987 is still in the queue but at the moment I don't think it should have any merge conflicts. |
|
Alright, seems like it didn't conflict. @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 3, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#99933 (parallelize HTML checking tool) - rust-lang#99958 (Improve position named arguments lint underline and formatting names) - rust-lang#100008 (Update all pre-cloned submodules on startup) - rust-lang#100049 (:arrow_up: rust-analyzer) - rust-lang#100070 (Clarify Cargo.toml comments) - rust-lang#100074 (rustc-docs: Be less specific about the representation of `+bundle`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For named arguments used as implicit position arguments, underline both
the opening curly brace and either:
closing curl brace or the
:denoting the start of formatting args)whitespace like
{ })This should make it more obvious where the named argument should be.
Additionally, in the lint message, emit the formatting argument names
without a dollar sign to avoid potentially confusion.
Fixes #99907