uefi: Add OwnedEvent abstraction #138236

Ayush1325 · 2025-03-08T19:44:17Z

Events are going to become quite important for Networking, so needed owned abstractions.
Switch to OwnedEvent abstraction for Exit boot services event.

rustbot · 2025-03-08T19:44:21Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Mark-Simulacrum · 2025-03-15T14:41:56Z

cc @dvdhrm as well (other uefi platform maintainer)

r=me with approval from either uefi maintainer

library/std/src/sys/pal/uefi/helpers.rs

- Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. Signed-off-by: Ayush Singh <[email protected]>

nicholasbishop · 2025-03-16T19:47:07Z

lgtm

Ayush1325 · 2025-03-17T03:18:12Z

I think this is what you mean, but I am not sure.

@bors r=Mark-Simulacrum

bors · 2025-03-17T03:18:15Z

@Ayush1325: 🔑 Insufficient privileges: Not in reviewers

Ayush1325 · 2025-03-18T04:30:47Z

@nicholasbishop I think you can merge this now since you are in reviewers for this PR: https://internals.rust-lang.org/t/what-does-r-me-mean/2620

nicholasbishop · 2025-03-18T04:38:48Z

I don't have committer privileges, so I don't think I can do that.

nicholasbishop · 2025-03-18T04:38:53Z

@rustbot review

petrochenkov · 2025-03-21T12:06:31Z

r? @petrochenkov
@bors r+ rollup

bors · 2025-03-21T12:06:34Z

📌 Commit aa2c24b has been approved by petrochenkov

It is now in the queue for this repository.

uefi: Add OwnedEvent abstraction - Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. cc `@nicholasbishop`

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc `@nicholasbishop` `@dvdhrm`

uefi: Add OwnedEvent abstraction - Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. cc ``@nicholasbishop``

Rollup of 10 pull requests Successful merges: - rust-lang#137736 (Don't attempt to export compiler-builtins symbols from rust dylibs) - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138321 ([bootstrap] Distribute split debuginfo if present) - rust-lang#138410 (Couple mir building cleanups) - rust-lang#138490 (Forward `stream_position` in `Arc<File>` as well) - rust-lang#138535 (Cleanup `LangString::parse`) - rust-lang#138536 (stable_mir: Add `MutMirVisitor`) - rust-lang#138580 (resolve: Avoid some unstable iteration 2) - rust-lang#138601 (add FCW to warn about wasm ABI transition) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) r? `@ghost` `@rustbot` modify labels: rollup

uefi: Add OwnedEvent abstraction - Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. cc `@nicholasbishop`

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc `@nicholasbishop` `@dvdhrm`

Rollup of 9 pull requests Successful merges: - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138602 (Slim `rustc_parse_format` dependencies down) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138641 (Add unstable `--print=supported-crate-types` option) - rust-lang#138662 (Implement some basics in UEFI fs) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) Failed merges: - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) r? `@ghost` `@rustbot` modify labels: rollup

uefi: Add OwnedEvent abstraction - Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. cc ``@nicholasbishop``

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc ``@nicholasbishop`` ``@dvdhrm``

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138662 (Implement some basics in UEFI fs) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) r? `@ghost` `@rustbot` modify labels: rollup

uefi: Add OwnedEvent abstraction - Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. cc ```@nicholasbishop```

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 12 pull requests Successful merges: - rust-lang#136040 (Remove unused trait BoundedSize) - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138545 (Add MIR pre-codegen tests to track rust-lang#138544) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138641 (Add unstable `--print=supported-crate-types` option) - rust-lang#138667 (std: uefi: fs: Implement mkdir) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) - rust-lang#138854 (Fix ICE rust-lang#138415 for invalid extern function body) - rust-lang#138858 (Say which test failed the `COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS` assertion) - rust-lang#138861 (Tweak type flags, fix missing flags from coroutine kind ty) Failed merges: - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 12 pull requests Successful merges: - rust-lang#136040 (Remove unused trait BoundedSize) - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138545 (Add MIR pre-codegen tests to track rust-lang#138544) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138641 (Add unstable `--print=supported-crate-types` option) - rust-lang#138667 (std: uefi: fs: Implement mkdir) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) - rust-lang#138854 (Fix ICE rust-lang#138415 for invalid extern function body) - rust-lang#138858 (Say which test failed the `COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS` assertion) - rust-lang#138861 (Tweak type flags, fix missing flags from coroutine kind ty) Failed merges: - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#138236 (uefi: Add OwnedEvent abstraction) - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates) - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474)) - rust-lang#138631 (Update test for SGX now implementing `read_buf`) - rust-lang#138837 (resolve: Avoid remaining unstable iteration) - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#138236 - Ayush1325:uefi-event, r=petrochenkov uefi: Add OwnedEvent abstraction - Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. cc ````@nicholasbishop````

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc `@nicholasbishop` `@dvdhrm`

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc ``@nicholasbishop`` ``@dvdhrm``

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc ```@nicholasbishop``` ```@dvdhrm```

…hop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc ````@nicholasbishop```` ````@dvdhrm````

Rollup merge of rust-lang#138662 - Ayush1325:uefi-fs-1, r=nicholasbishop,petrochenkov Implement some basics in UEFI fs - Just getting some basics out of the way while waiting for rust-lang#138236 to be merged. - Adds `fs::canonicalize`. Should be same as absolute in case of UEFI since there is no symlink support and absolute path is guaranteed to be uniqe according to spec. - Make `fs::lstat` same as `fs::stat`. Should be same since UEFI does not have symlink support. - Implement `OptionOptions`. cc ````@nicholasbishop```` ````@dvdhrm````

rustbot assigned Mark-Simulacrum Mar 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 8, 2025

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2025

nicholasbishop suggested changes Mar 16, 2025

View reviewed changes

library/std/src/sys/pal/uefi/helpers.rs Show resolved Hide resolved

library/std/src/sys/pal/uefi/helpers.rs Outdated Show resolved Hide resolved

library/std/src/sys/pal/uefi/helpers.rs Outdated Show resolved Hide resolved

Ayush1325 force-pushed the uefi-event branch from 38c71d5 to 81f7908 Compare March 16, 2025 19:27

uefi: Add OwnedEvent abstraction

aa2c24b

- Events are going to become quite important for Networking, so needed owned abstractions. - Switch to OwnedEvent abstraction for Exit boot services event. Signed-off-by: Ayush Singh <[email protected]>

Ayush1325 force-pushed the uefi-event branch from 81f7908 to aa2c24b Compare March 16, 2025 19:44

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2025

This was referenced Mar 18, 2025

Implement some basics in UEFI fs #138662

Merged

Tracking Issue for uefi-std #100499

Open

rustbot assigned petrochenkov Mar 21, 2025

rustbot unassigned Mark-Simulacrum Mar 21, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025

Kobzol mentioned this pull request Mar 21, 2025

Rollup of 10 pull requests #138792

Closed

tgross35 mentioned this pull request Mar 22, 2025

Rollup of 10 pull requests #138827

Closed

jieyouxu mentioned this pull request Mar 23, 2025

Rollup of 9 pull requests #138853

Closed

matthiaskrgr mentioned this pull request Mar 23, 2025

Rollup of 7 pull requests #138856

Closed

matthiaskrgr mentioned this pull request Mar 23, 2025

Rollup of 6 pull requests #138859

Closed

compiler-errors mentioned this pull request Mar 23, 2025

Rollup of 12 pull requests #138866

Merged

bors merged commit d7c5f5f into rust-lang:master Mar 24, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 24, 2025

Ayush1325 deleted the uefi-event branch March 24, 2025 02:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uefi: Add OwnedEvent abstraction #138236

uefi: Add OwnedEvent abstraction #138236

Ayush1325 commented Mar 8, 2025

rustbot commented Mar 8, 2025

Mark-Simulacrum commented Mar 15, 2025

nicholasbishop commented Mar 16, 2025

Ayush1325 commented Mar 17, 2025

bors commented Mar 17, 2025

Ayush1325 commented Mar 18, 2025 •

edited

Loading

nicholasbishop commented Mar 18, 2025

nicholasbishop commented Mar 18, 2025

petrochenkov commented Mar 21, 2025

bors commented Mar 21, 2025

uefi: Add OwnedEvent abstraction #138236

uefi: Add OwnedEvent abstraction #138236

Conversation

Ayush1325 commented Mar 8, 2025

rustbot commented Mar 8, 2025

Mark-Simulacrum commented Mar 15, 2025

nicholasbishop commented Mar 16, 2025

Ayush1325 commented Mar 17, 2025

bors commented Mar 17, 2025

Ayush1325 commented Mar 18, 2025 • edited Loading

nicholasbishop commented Mar 18, 2025

nicholasbishop commented Mar 18, 2025

petrochenkov commented Mar 21, 2025

bors commented Mar 21, 2025

Ayush1325 commented Mar 18, 2025 •

edited

Loading