Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to ensure no index out of bounds panic (#135474) #138509

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Add test to ensure no index out of bounds panic (#135474) #138509

merged 1 commit into from
Mar 24, 2025
+44 −0

Conversation

reddevilmidzy
Copy link
Contributor

Adds test for #135474

@rustbot
Copy link
Collaborator

rustbot commented Mar 14, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 14, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
compiler-errors
compiler-errors requested changes Mar 14, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs a better name and should be placed into a subdirectory of tests/ui corresponding to what the test is exercising, rather than the top-level.

Specifically, I think you should look back at the original issue and/or the PR that fixed the issue to understand what was wrong with the code in the first place and/or why the issue was fixed, so that this can be named more accurately.

@compiler-errors
Copy link
Member

@rustbot author
r? compiler-errors

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2025
@rustbot rustbot assigned compiler-errors and unassigned davidtwco Mar 14, 2025
@reddevilmidzy
Copy link
Contributor Author

Thanks for the feedback! I've moved the test to the tests/ui/fn directory. I also reviewed the original PR (#136497) to better understand the context and ensure the test is more accurately placed.

Additionally, I've renamed the test from impl-sized to trait-fn-generic-mismatch

Let me know if you have any further suggestions!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2025
@compiler-errors
Copy link
Member

Please squash this into one commit. there doesn't need to be a commit to move a file or to remove whitespace, for example. It's just one file after all :) Then I can approve.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025
@reddevilmidzy
Copy link
Contributor Author

Squashed the commits into one as requested. Thanks for the review! 😊

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 22, 2025
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 22, 2025

📌 Commit b523301 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2025
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Mar 23, 2025
@jieyouxu
Rollup merge of rust-lang#138509 - reddevilmidzy:add-test, r=compiler…
21d89ff 
…-errors

Add test to ensure no index out of bounds panic (rust-lang#135474)

Adds test for rust-lang#135474
@jieyouxu jieyouxu mentioned this pull request Mar 23, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
@bors
Auto merge of rust-lang#138853 - jieyouxu:rollup-ogjxuq9, r=jieyouxu
ec48f81 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138602 (Slim `rustc_parse_format` dependencies down)
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138641 (Add unstable `--print=supported-crate-types` option)
 - rust-lang#138662 (Implement some basics in UEFI fs)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)

Failed merges:

 - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#138509 - reddevilmidzy:add-test, r=compiler…
3bbe70d 
…-errors

Add test to ensure no index out of bounds panic (rust-lang#135474)

Adds test for rust-lang#135474
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 23, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
@bors
Auto merge of rust-lang#138856 - matthiaskrgr:rollup-o5c20kr, r=matth…
1f9fad5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138662 (Implement some basics in UEFI fs)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2025
@matthiaskrgr
Rollup merge of rust-lang#138509 - reddevilmidzy:add-test, r=compiler…
65dd23a 
…-errors

Add test to ensure no index out of bounds panic (rust-lang#135474)

Adds test for rust-lang#135474
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 23, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
@bors
Auto merge of rust-lang#138859 - matthiaskrgr:rollup-9s1a68j, r=matth…
d192d20 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)

r? `@ghost`
`@rustbot` modify labels: rollup
@compiler-errors compiler-errors mentioned this pull request Mar 23, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
@bors
Auto merge of rust-lang#138866 - compiler-errors:rollup-9d8v3mz, r=co…
2120459 
…mpiler-errors

Rollup of 12 pull requests

Successful merges:

 - rust-lang#136040 (Remove unused trait BoundedSize)
 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138545 (Add MIR pre-codegen tests to track rust-lang#138544)
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138641 (Add unstable `--print=supported-crate-types` option)
 - rust-lang#138667 (std: uefi: fs: Implement mkdir)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)
 - rust-lang#138854 (Fix ICE rust-lang#138415 for invalid extern function body)
 - rust-lang#138858 (Say which test failed the `COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS` assertion)
 - rust-lang#138861 (Tweak type flags, fix missing flags from coroutine kind ty)

Failed merges:

 - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
@bors
Auto merge of rust-lang#138859 - matthiaskrgr:rollup-9s1a68j, r=matth…
d2e943b 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2025
@bors
Auto merge of rust-lang#138866 - compiler-errors:rollup-9d8v3mz, r=co…
7290b04 
…mpiler-errors

Rollup of 12 pull requests

Successful merges:

 - rust-lang#136040 (Remove unused trait BoundedSize)
 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138545 (Add MIR pre-codegen tests to track rust-lang#138544)
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138641 (Add unstable `--print=supported-crate-types` option)
 - rust-lang#138667 (std: uefi: fs: Implement mkdir)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)
 - rust-lang#138854 (Fix ICE rust-lang#138415 for invalid extern function body)
 - rust-lang#138858 (Say which test failed the `COMPILETEST_REQUIRE_ALL_LLVM_COMPONENTS` assertion)
 - rust-lang#138861 (Tweak type flags, fix missing flags from coroutine kind ty)

Failed merges:

 - rust-lang#138755 ([rustdoc] Remove duplicated loop when computing doc cfgs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6756e3d into rust-lang:master Mar 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 24, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025
@bors
Auto merge of rust-lang#138859 - matthiaskrgr:rollup-9s1a68j, r=matth…
4dd40af 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#138236 (uefi: Add OwnedEvent abstraction)
 - rust-lang#138293 (rustdoc: Gate unstable `doc(cfg())` predicates)
 - rust-lang#138509 (Add test to ensure no index out of bounds panic (rust-lang#135474))
 - rust-lang#138631 (Update test for SGX now implementing `read_buf`)
 - rust-lang#138837 (resolve: Avoid remaining unstable iteration)
 - rust-lang#138849 (doc: rename reference #create-a-configtoml to #create-a-bootstraptoml)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2025
@rust-timer
Unrolled build for rust-lang#138509
ed30b30 
Rollup merge of rust-lang#138509 - reddevilmidzy:add-test, r=compiler-errors

Add test to ensure no index out of bounds panic (rust-lang#135474)

Adds test for rust-lang#135474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors Awaiting requested review from compiler-errors

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
6 participants
@reddevilmidzy @rustbot @rust-log-analyzer @compiler-errors @bors @davidtwco