Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent parameter name for numeric ‘checked’ operations. #46473

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Consistent parameter name for numeric ‘checked’ operations. #46473

merged 1 commit into from
Dec 4, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 3, 2017

Some checked operations use rhs as a parameter name, and some use
other. For the sake of consistency, unify everything under the rhs
name.

Fixes #46308.

@frewsxcv
Consistent parameter name for numeric ‘checked’ operations.
a2d87d8 
Some checked operations use `rhs` as a parameter name, and some use
`other`. For the sake of consistency, unify everything under the `rhs`
name.

Fixes rust-lang#46308.
@rust-highfive
Copy link
Collaborator

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Dec 3, 2017
@TimNN
Copy link
Contributor

TimNN commented Dec 3, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 3, 2017

📌 Commit a2d87d8 has been approved by TimNN

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 3, 2017
@frewsxcv
Rollup merge of rust-lang#46473 - frewsxcv:frewsxcv-param-name, r=TimNN
48d3855 
Consistent parameter name for numeric ‘checked’ operations.

Some checked operations use `rhs` as a parameter name, and some use
`other`. For the sake of consistency, unify everything under the `rhs`
name.

Fixes rust-lang#46308.
@frewsxcv frewsxcv mentioned this pull request Dec 3, 2017
Merged
bors added a commit that referenced this pull request Dec 3, 2017
@bors
Auto merge of #46482 - frewsxcv:rollup, r=frewsxcv
fdfbcf8 
Rollup of 8 pull requests

- Successful merges: #45957, #46260, #46432, #46442, #46454, #46462, #46465, #46473
- Failed merges:
@bors bors merged commit a2d87d8 into rust-lang:master Dec 4, 2017
@bors
Copy link
Contributor

bors commented Dec 4, 2017

⌛ Testing commit a2d87d8 with merge fdfbcf8...

@frewsxcv frewsxcv deleted the frewsxcv-param-name branch December 19, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TimNN TimNN

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @TimNN @bors @kennytm