Rollup of 8 pull requests #46482
Merged
Rollup of 8 pull requests #46482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frewsxcv
commented
Dec 3, 2017
frewsxcv
commented
- Successful merges: Use more convenient and UNIX-agnostic shebang #45957, Make doc stubs for builtin macros reflect existing support for trailing commas #46260, Fix documentation for DecodeUtf16Error #46432, Remove an unstable and dead compiler flag #46442, Fix search results overlap #46454, Fix CopyPropagation regression (2) #46462, Fix invalid link to lint_plugin_test.rs #46465, Consistent parameter name for numeric ‘checked’ operations. #46473
- Failed merges:
When using bash-specific features, scripts using env to call bash are more convenient, as bash be installed in different places according the OS. Same applies for other languages' interpreters.
The last use has been removed by commit fb9ca16 .
Some checked operations use `rhs` as a parameter name, and some use `other`. For the sake of consistency, unify everything under the `rhs` name. Fixes rust-lang#46308.
…aster Use more convenient and UNIX-agnostic shebang When using bash-specific features, scripts using env to call bash are more convenient, as bash be installed in different places according the OS.
…veklabnik Make doc stubs for builtin macros reflect existing support for trailing commas This modifies the `macro_rules!` stubs in `std` for some of the compiler builtin macros in order to better reflect their currently supported grammar. To my understanding these stubs have no impact on compiler output whatsoever, and only exist so that they may appear in the documentation. P.S. It is in fact true that `env!` supports trailing commas while `option_env!` currently does not. (I have another issue for this) I don't imagine there's any way to automatically test these stubs, but I did *informally* test the new definitions on the playpen to see that they accept the desired invocations, as well as inspect the updated doc output.
Fix documentation for DecodeUtf16Error Fixes rust-lang#46307
Remove an unstable and dead compiler flag The last use has been removed by commit fb9ca16 .
…ietMisdreavus Fix search results overlap Fixes rust-lang#46434. r? @QuietMisdreavus
Fix CopyPropagation regression (2) Remaining part of MIR copyprop regression by (I think) rust-lang#45380, which I missed in rust-lang#45753. ```rust fn foo(mut x: i32) -> i32 { let y = x; x = 123; // `x` is assigned only once in MIR, but cannot be propagated to `y` y } ``` So any assignment to an argument cannot be propagated.
Fix invalid link to lint_plugin_test.rs The path to `lint_plugin_test.rs` was moved to `src/test/ui-fulldeps/` from `src/test/run-pass-fulldeps/` in rust-lang@38ef856 This patch updates it in the docs.
Consistent parameter name for numeric ‘checked’ operations. Some checked operations use `rhs` as a parameter name, and some use `other`. For the sake of consistency, unify everything under the `rhs` name. Fixes rust-lang#46308.
|
@bors r+ p=10 |
|
Some changes occurred in HTML/CSS. |
|
📌 Commit 48d3855 has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Dec 3, 2017
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.