Remove all the "is_[A-Z].*" from global namespace

[ppurka]

Remove all the is_[A-Z].* from global namespace. They have been deprecated for over two years.

step 1) remove the imports of is_* from rings/all.py (#15076)

step 2) remove the imports of is_* from matrix/all.py (#15098)

step 3) idem for modules/all.py and structure/all.py (#15333)

step 4) remove otherwise unused (i.e., not re-imported) imports of is_[A-Z]* (this ticket)

step 5) remove the remaining imports of is_[A-Z]* (this ticket)

Depends on #15076
Depends on #15098
Depends on #15333

Component: performance

Author: Marc Mezzarobba

Branch/Commit: b948874

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/14329

[kini]

comment:1

Do you mean is_[A-Z][A-Za-z]*?

[ppurka]

comment:2

Arrgghhh! regexp!! There, the current modification should suffice.

On a serious note, what I do mean is all the "is_Vector", "is_Polynomial", "is_Matrix", and what not. The patch will be trivial but tiresome. I don't know any means of listing and testing whether they give a deprecation warning automatically. So, it has to be a slow, manual, and visual process.

[kini]

comment:3

import re
from subprocess import check_output, STDOUT, CalledProcessError
for x in globals().keys():
    if re.match("is_[A-Z]", x) is not None:
        try:
            output = check_output(['sage', '-c', x + '(None)'], stderr=STDOUT)
        except CalledProcessError as e:
            output = e.output
        if re.match(".*DeprecationWarning", output) is not None:
            print x

is a hack but should work.

[nathanncohen]

comment:4

(cc me)

[tscrim]

comment:5

This is a duplicate of #12824.

[ppurka]

comment:6

I was definitely not advocating removing the functions themselves. They can still be used internally. Is it desired that the functions themselves are removed?

[tscrim]

comment:7

Since they've already been deprecated (from the global namespace in #10107), the trivial ones can be removed since we don't really want to use them IMO (a extra unnecessary python function call). Perhaps we could just use this ticket to explicitly remove these functions only from the global namespace (as a step towards #12824)?

[ppurka]

comment:8

Yes. That was my intention. :-)

[tscrim]

comment:9

Ah okay, then this patch would just be a matter of finding which all.py files are importing these...

[fchapoton]

comment:11

As a first step I propose #15076

[fchapoton]

comment:13

step 1) should be ok and is wating for review at #15076

[pjbruin]

comment:24

There are still dozens of is_* functions in the global namespace; is_Radix64StringMonoidElement, just to name a random example arising from typing is_[tab] in Sage 6.3.beta1. Shouldn't there be some more steps like 1-3 in the ticket description before we can remove the warning?

[mezzarobba]

comment:25

Replying to @pjbruin:

There are still dozens of is_* functions in the global namespace; is_Radix64StringMonoidElement, just to name a random example arising from typing is_[tab] in Sage 6.3.beta1. Shouldn't there be some more steps like 1-3 in the ticket description before we can remove the warning?

Looks like you are completely right! I don't remember why I thought we were done.

Btw many of the imports that were supposed to be removed as part of steps 1)-3) are still there (or were added back?).

[mezzarobba]

Changed author from Marc Mezzarobba to none

[sagetrac-git]

Changed commit from 04a9dc7 to 064e29f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ef52d40	rm global is_EllipticCurve
275ecb3	rm global is_HyperellipticCurve
e055984	rm global is_{Expect,Gap,Singular}Element
b0d2cd0	rm global is_Finite_Field, is_Finite_FieldElement
9d2363d	rm global is_Graphics
03fb568	rm global is_ProjectiveSpace
07f24db	rm global is_QuadraticForm
ccb3ac7	rm global is_Scheme
da22e56	rm global is_Morphism
064e29f	global is_*: delete deprecation warning

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

9e0f8ad	rm global is_EllipticCurve
dd3e424	rm global is_HyperellipticCurve
e71d0cb	rm global is_{Expect,Gap,Singular}Element
0aa3b40	rm global is_Finite_Field, is_Finite_FieldElement
b0dc1cf	rm global is_Graphics
de6835b	rm global is_ProjectiveSpace
037eae0	rm global is_QuadraticForm
5af32ad	rm global is_Scheme
95ddc08	rm global is_Morphism
a616a71	global is_*: delete deprecation warning

[sagetrac-git]

Changed commit from 064e29f to a616a71

[mezzarobba]

comment:28

Work in progress, only partially tested, expect forced pushes!

[sagetrac-git]

Changed commit from a616a71 to b948874

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

638875b	rm global is_EllipticCurve
e620d38	rm global is_HyperellipticCurve
1932b64	rm global is_{Expect,Gap,Singular}Element
3841cc7	rm global is_Finite_Field, is_Finite_FieldElement
ae72be9	rm global is_Graphics
f0ac47d	rm global is_ProjectiveSpace
bd2b01a	rm global is_QuadraticForm
fa34d62	rm global is_Scheme
8ad8402	rm global is_Morphism
b948874	global is_*: delete deprecation warning

[mezzarobba]

Author: Marc Mezzarobba

[mezzarobba]

comment:30

This time there are no is_[A-Z]* remaining in the global namespace and all (long) tests pass.

Note that I did not remove is_pAdic{Ring,Field} since these were not formally deprecated as far as I understand (but I would not mind removing them as well if other people agree).

[pjbruin]

Reviewer: Peter Bruin

[pjbruin]

comment:31

I would be in favour of removing is_pAdic{Ring,Field} as well, but it's better to deprecate them first. We can do it in a future round of cleaning up the global namespace.

[vbraun]

Changed branch from u/mmezzarobba/14329-remove_is_foo to b948874