remove import of is_* in rings.all

[fchapoton]

As a big first step towards #14329, I propose to remove all imports of methods is_[A-Z] in sage/rings/all.py

CC: @ppurka @nathanncohen

Component: build

Keywords: deprecation cleanup

Author: Frédéric Chapoton

Reviewer: Nathann Cohen

Merged: sage-5.13.beta1

Issue created by migration from https://trac.sagemath.org/ticket/15076

[fchapoton]

Author: Frédéric Chapoton

[fchapoton]

comment:1

This should be ok, unless I have made a mistake

This is a little "patchbomb", so it would be great if it could be reviewed quickly.

[fchapoton]

comment:2

Well, I have only taken care of what happens at startup !

There probably remains many imports not triggered at startup..

Let us see what the bot says.

[fchapoton]

comment:4

I have made sure that tests pass in

• schemes/elliptic_curves
• combinat

but of course, there are many other places where to look ..

[fchapoton]

comment:5

ok, this should be ready for review. It would be great if the bot could run on the ticket..

apply trac_15076_remove_global_is_in_rings.patch

[fchapoton]

comment:7

new version of the patch, that hopefully the bot will like

[fchapoton]

comment:8

apply only trac_15076_remove_global_is_in_rings.patch​

[fchapoton]

comment:9

apply only trac_15076_remove_global_is_in_rings.patch

[fchapoton]

comment:10

apply only trac_15076_remove_global_is_in_rings.patch

[fchapoton]

Attachment: trac_15076_remove_global_is_in_rings.patch.gz

replaces previous patch

[fchapoton]

comment:11

apply only trac_15076_remove_global_is_in_rings.patch

[fchapoton]

comment:12

Hey, the bot is happy ! Is there anybody wanting to review this patch ?

[nathanncohen]

comment:13

Oh. Well, if it is happy... :-)

Nathann

[nathanncohen]

comment:14

Hmmmmmmmm.... O_o

Actually I wonder if those methods shouldn't be deprecated first, as those who used them may not know where they moved... O_o

I used deprecated_callable_import in #14499, isn't it what should be used there too ?

Nathann

[ppurka]

comment:15

These were deprecated for many years. Try them in vanilla sage.

[nathanncohen]

comment:16

Oh I see ! But then why don't we just remove the deprecated version of the functions too ? It looks like the deprecated functions are not in the namespace anymore, but that they are still defined -- and deprecated somewhere O_o ?

Nathann

[fchapoton]

comment:17

What do you mean ?

These functions are not deprecated, it's their import in the global namespace that is.

By the way, even after these patch, some of them will still be imported in the global namespace, and a follow-up ticket will be needed. I prefer to proceed step-by-step.

[nathanncohen]

comment:18

Oh. Well, what I wondered is which part of the code deprecated the version of these is_* functions that appears in the global namespace. I wondered why this code would not be removed by the current patch.

But I just noticed that it was actually a global piece of code, which deprecated all these is_* functions together, and thus is not to be removed by this patch.

Anyway : all is good, and this patch can go. My excuses for the delay ;-)

Nathann

[nathanncohen]

Reviewer: Nathann Cohen

[nathanncohen]

comment:19

(and here is where this global piece of code was added, just in case somebody else would like to know : #10107)

[ppurka]

comment:20

Thanks for looking into this Nathann. I really didn't get time to dig into this patch.

[jdemeyer]

Merged: sage-5.13.beta1