Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with bad chosen representations of k-regular sequences #21343

Closed
dkrenn opened this issue Aug 26, 2016 · 27 comments · Fixed by #35896
Closed

deal with bad chosen representations of k-regular sequences #21343

dkrenn opened this issue Aug 26, 2016 · 27 comments · Fixed by #35896

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Aug 26, 2016

Deal with the troubles coming from bad chosen representations of k-regular sequences, where mu[0]*right != right. (This makes troubles as leading zeros of digit expansions should not influence the result.)

Depends on #21204

Component: combinatorics

Author: Daniel Krenn

Branch/Commit: u/dkrenn/k-regular-warning @ 4af416c

Issue created by migration from https://trac.sagemath.org/ticket/21343

@dkrenn dkrenn added this to the sage-7.4 milestone Aug 26, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 26, 2016

Dependencies: #21204

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 26, 2016

Branch: u/dkrenn/k-regular-warning

@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 26, 2016

Changed branch from u/dkrenn/k-regular-warning to none

@dkrenn dkrenn changed the title bad chosen representations of k-regular sequences deal with bad chosen representations of k-regular sequences Aug 26, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 26, 2016

Branch: u/dkrenn/k-regular-warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

352751eMerge tag '7.4.beta2' into t/21295/sequences/recognizable
914640fMerge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
c0ade99Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
35807dfMerge branch 't/21318/sequences/rec-basic-arith' into t/21319/sequences/rec-hash
a2fe6f3Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
e4cec17minor correction in doc
3a4e849Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
c8a86dbMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
0dae02bMerge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-regular-guess
5b7b85aMerge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regular-warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Commit: 5b7b85a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

1d64e84some_elements: pass keyword arguments to element constructor
e02018boverride some_elements in kRegularSequenceSpace and activate healing
18c5268correct typo in docstring
a716121Merge branch 't/21319/sequences/rec-hash' into t/21343/k-regular-warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 2, 2016

Changed commit from 5b7b85a to a716121

@cheuberg
Copy link
Contributor

cheuberg commented Jan 5, 2017

comment:7

failing doctests (cf. patchbot), python3 plugin

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Changed commit from a716121 to e25b8d2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 24, 2017

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

4da9796Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
13b536ePython3: absolut import
5919c4dMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
9086b64Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
fc6c3f5Python3: xrange
714276cMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
457aefdPython3: fix iteritems
fcb53a3fix doctest output of TestSuite (new tests were added)
bde8e67Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-regular-guess
e25b8d2Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regular-warning

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 24, 2017

comment:9

Replying to @cheuberg:

failing doctests (cf. patchbot), python3 plugin

Fixed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c2bf1b8Merge tag '8.1' into u/dkrenn/sequences/recognizable
fef79b2Merge branch 'u/dkrenn/sequences/recognizable' into u/dkrenn/sequences/k-regular
8eda76eMerge branch 'u/dkrenn/sequences/k-regular' into u/dkrenn/sequences/rec-basic-arith
0c83557Merge branch 'u/dkrenn/sequences/rec-basic-arith' into u/dkrenn/sequences/k-regular-subseq
e30a7fbMerge branch 'u/dkrenn/sequences/k-regular-subseq' into u/dkrenn/sequences/rec-hash
622c3f6Merge branch 'u/dkrenn/sequences/rec-hash' into u/dkrenn/sequences/k-regular-guess
dde1700Merge branch 'u/dkrenn/sequences/k-regular-guess' into u/dkrenn/k-regular-warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 6, 2018

Changed commit from e25b8d2 to dde1700

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2019

Changed commit from dde1700 to 3b0f9d0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 29, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

5dbdcbbMerge tag '8.7' into u/dkrenn/sequences/recognizable
d17def8Merge branch 'u/dkrenn/sequences/recognizable' into u/dkrenn/sequences/k-regular
2b998baMerge branch 'u/dkrenn/sequences/k-regular' into u/dkrenn/sequences/rec-basic-arith
1f8c2a1Merge branch 'u/dkrenn/sequences/rec-basic-arith' into u/dkrenn/sequences/k-regular-subseq
a87520eMerge branch 'u/dkrenn/sequences/k-regular-subseq' into u/dkrenn/sequences/rec-hash
4e7f615Merge branch 'u/dkrenn/sequences/rec-hash' into u/dkrenn/sequences/k-regular-guess
3b0f9d0Merge branch 'u/dkrenn/sequences/k-regular-guess' into u/dkrenn/k-regular-warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2019

Changed commit from 3b0f9d0 to 848565f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 2, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

21ed597Trac #21343: fix doctest some_elements
848565fTrac #21343: rename to "degenerate" and co

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

a117f51Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
0f8fb2eTrac #21318: fixup due to recent changes in dependencies
4e967fdMerge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
1ead378Merge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
15b0405Trac #21319: fixup due to changes in dependencies
e726278Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-regular-guess
dcc7cd1Trac #21204: cherry-pick to avoid merge conflict
c0519f0Trac #21204: fixup code and tests
8488b55Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regular-warning
f776785Trac #21343: adapt to removed transpose-property in dependency

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2021

Changed commit from 848565f to f776785

@dkrenn
Copy link
Contributor Author

dkrenn commented May 11, 2021

comment:15

tranpose was removed due to the discussion started at #21295 comment:32 issue 6. This lead to a non-minor change here, as dealing with regenerated sequences and transposing sequences needs to go hand-in-hand during construction. I now remember, that this was the original motivation for having transpose in the constructor. However, I have now created a solution here adapting to this situation.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

d4e1d1fTrac #21318: rmul/lmul preserve identity for multiplying by 1
e66ff5eTrac #21325: fixup test .subsequence being identity
c70f8dbTrac #21318: rmul/lmul preserve identity for multiplying by 1
030162aMerge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
cff550eMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
93c6687Trac #21319: fix punctuation
5ce5276Merge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-regular-guess
00047ceTrac #21204: fix punctuation
fb5fb62Merge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regular-warning
9b59022Trac #21343: fix punctuation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2021

Changed commit from f776785 to 9b59022

@dkrenn
Copy link
Contributor Author

dkrenn commented Jun 25, 2021

comment:17

Merged dependencies; ready for review.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2022

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

5b2fb5cTrac #21325 review comment 12: fixup docstring partial_sums
3b7c431Trac #21325 review comment 13: use .linear representation in examples partial_sum
33d4daeTrac #21325 review comment 14+15: rewrite construction dict
ecb3663Trac #21325 review comment 17: simpler (more readable) construction of block matrix
96df7b3Trac #21325 review comment 18: deal with remaining block vectors
26e2d6fTrac #21325 review comment 19: shift_left, shift_right
b4f83e4Merge branch 'u/dkrenn/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
9fefcceFollow-up from Trac #21325 review comment 19: shift_left+right: test equality
3c634dfMerge branch 't/21319/sequences/rec-hash' into t/21204/sequences/k-regular-guess
4af416cMerge branch 't/21204/sequences/k-regular-guess' into t/21343/k-regular-warning

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 5, 2022

Changed commit from 9b59022 to 4af416c

@fchapoton
Copy link
Contributor

comment:19

red branch => needs work

@fchapoton fchapoton modified the milestones: sage-7.4, sage-9.7 May 12, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
vbraun pushed a commit that referenced this issue Jul 30, 2023
gh-35896: deal with bad chosen representations of k-regular sequences
    
### 📚 Description

It deals with the situation when mu[0]*right != right in k-regular
sequences.

Fixes #21343. This PR is created from the branch/code that has been on
the corresponding trac ticket + merging in a current SageMath version.

See also meta issue #21202.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

- #21204: guessing k-regular sequences from the first few values

No formal dependencies, but there are trivial merge conflicts---in both
branches, methods are inserted at the same position in the code---
between:
- #21343: deal with mu[0]*right != right in k-regular sequences
- #35894: Regular sequences: implement convolution / ring structure
    
URL: #35896
Reported by: Daniel Krenn
Reviewer(s): cheuberg, Daniel Krenn
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 30, 2023
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
…ounded

* u/dkrenn/k-regular-warning:
  Trac sagemath#21343: rename to "degenerate" and co
  Trac sagemath#21343: fix doctest some_elements
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
* t/21343/k-regular-warning: (11523 commits)
  Trac sagemath#21343: adapt to removed transpose-property in dependency
  Trac sagemath#21204: fixup code and tests
  Trac sagemath#21204: cherry-pick to avoid merge conflict
  Trac sagemath#21319: fixup due to changes in dependencies
  Trac sagemath#21318: fixup due to recent changes in dependencies
  Updated SageMath version to 9.3
  build/pkgs/fplll/spkg-install.in: Configure --without-qd if we use gcc from spkg
  build/pkgs/fplll/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/ppl/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/brial/spkg-configure.m4: Add depcheck on gcc
  build/pkgs/{freetype,libgd}/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/zeromq/spkg-configure.m4: Add depcheck for gcc
  build/pkgs/ntl/spkg-configure.m4: Add depcheck for gcc
  Trac sagemath#21295 review issue 29: notice minimize vs field
  Trac sagemath#21295 review issue 7: document accessing coefficients
  Trac sagemath#21295 review issue 33: rename to number_of_zeros (as it should be)
  Trac sagemath#21203 review issue 4: rename to coefficient ring
  Trac sagemath#21295: rename to coefficient_ring
  Trac sagemath#21203 review issue 3: example for __getitem__ and __iter__
  Trac sagemath#21203 review issue 2: extend odds in Pascal's triangle
  ...
vbraun pushed a commit that referenced this issue Aug 5, 2023
gh-35894: Regular sequences: implement convolution / ring structure
    
### 📚 Description

Add/implement convolution of two regular sequences, therefore making the
parent a ring.

Details of the algorithm: [convolution-sagemath-pr-
35894.pdf](https://github.com/sagemath/sage/files/12216984/convolution-
sagemath-pr-35894.pdf)

See also meta issue #21202.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

No formal dependencies, but there are trivial merge conflicts---in both
branches, methods are inserted at the same position in the code---
between:
- #21343: deal with mu[0]*right != right in k-regular sequences
- #35894: Regular sequences: implement convolution / ring structure
    
URL: #35894
Reported by: Daniel Krenn
Reviewer(s): cheuberg, Daniel Krenn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants