-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: Add option --disable-cvxopt #32226
Comments
Commit: |
New commits:
|
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
I disagree. Most of Sage functionality is not used by sagelib, it's absolutely not a reason to remove it. A number of publications I have depend on this functionality, and perhaps more. |
comment:11
Note that this ticket does not remove The problem is that |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:15
What's the practical difference between standard-but-optional and plain optional? Is it just the default value of It's a tiny bit annoying to have to remember to |
comment:16
Replying to @orlitzky:
Kind of, but in addition to that, also controls what is packaged up in the source distribution |
Reviewer: Dima Pasechnik |
comment:17
OK, fine by me. |
comment:18
Thanks. |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/mkoeppe/downgrade_suitesparse__cvxopt_to__optional_ to |
sagemathgh-36567: `sage.numerical`: Update `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Also removing a function deprecated in sagemath#32226 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - In part cherry picked from sagemath#35095 - Part of sagemath#29705 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36567 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
sagemathgh-36567: `sage.numerical`: Update `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Also removing a function deprecated in sagemath#32226 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - In part cherry picked from sagemath#35095 - Part of sagemath#29705 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36567 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
sagemathgh-36567: `sage.numerical`: Update `# needs` <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> Also removing a function deprecated in sagemath#32226 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> - In part cherry picked from sagemath#35095 - Part of sagemath#29705 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36567 Reported by: Matthias Köppe Reviewer(s): David Coudert, Matthias Köppe
Given the brittle build system of
cvxopt
(#31905, #32087), and of its dependencysuitesparse
(#30478), we should give users a recourse when the installation fails.cvxopt
provides our only backend forSemidefiniteProgram
, introduced over 5 years ago. Although not yet used anywhere in the Sage library, it provides important functionality for a number of Sage user, e.g.it's used in https://github.com/bachirelkhadir/sdp_solvers_experiments which is needed for
demonstration of https://epubs.siam.org/doi/pdf/10.1137/19M1287584 in
https://github.com/bachirelkhadir/Convex-Quaternary-Quartics-Are-Sum-of-Squares/blob/master/optimal_constant_generalized_cs_deg_8_a4.pdf
Hence, we keep
cvxopt
as a standard package, but make it disablable.Marking doctests that depend on
cvxopt
with# optional - cvxopt
is also preparation for modularization. Thanks to the dummy backendMatrixSDPBackend
, the modeling side of the interface can still be doctested even ifcvxopt
is not installed.We also deprecate the outdated and unused global function
linear_program
, which directly usescvxopt
.CC: @dimpase @tscrim @orlitzky
Component: packages: standard
Author: Matthias Koeppe
Branch/Commit:
2ab2f15
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/32226
The text was updated successfully, but these errors were encountered: