Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.geometry: More # optional #32846

Closed
mkoeppe opened this issue Nov 10, 2021 · 29 comments
Closed

sage.geometry: More # optional #32846

mkoeppe opened this issue Nov 10, 2021 · 29 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.6

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 10, 2021

Depends on #32776
Depends on #32732
Depends on #32174
Depends on #32889

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 1c028c7

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32846
@mkoeppe mkoeppe added this to the sage-9.5 milestone Nov 10, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 10, 2021

Dependencies: #32776

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 10, 2021

Branch: u/mkoeppe/sage_geometry_polyhedron__more___optional

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

8085729src/sage/geometry: Mark more doctests # optional - sage.rings.number_field
0c5ed4csrc/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst: Add # optional - sage.rings.number_field, sage.symbolic
89267f8src/sage/geometry/polyhedron/backend_normaliz.py: Add more # optional - sage.rings.number_field
ebe5d22src/sage/geometry/polyhedron/base.py: Add more # optional - sage.rings.number_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Commit: ebe5d22

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 10, 2021

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title sage.geometry.polyhedron: More # optional sage.geometry: More # optional Nov 10, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 10, 2021

Changed dependencies from #32776 to #32776, #32732

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Changed commit from ebe5d22 to df22260

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

f32b992src/sage/features/sagemath.py (sage.combinat): Fix the name of the tested PythonModule
30eee2esrc/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Add another missing # optional - sage.plot
c1b1d93src/sage/geometry/polyhedron/plot.py: Add more # optional - sage.plot
eb31b22src/sage/geometry/voronoi_diagram.py: Add # optional - sage.rings.number_field
d1b3bcasrc/sage/geometry/integral_points.pyx: Add # optional - sage.rings.number_field
98522e0src/sage/numerical: Add # optional - sage.rings.number_field
b846c0asrc/sage/numerical/backends/interactivelp_backend.pyx: Add missing # optional
94999bcMerge #32732
a36005esrc/sage/geometry/polyhedron/parent.py: Add # optional - sage.rings.number_field
df22260src/sage/geometry/polyhedron/library.py: Add # optional - sage.rings.number_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

5d54e67src/sage/geometry/polyhedron/base.py: Add more # optional - sage.graphs, sage.combinat, sage.rings.number_field
47c97ccsrc/sage/geometry/polyhedron/base.py: Add # optional - sage.plot

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Changed commit from df22260 to 47c97cc

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Changed commit from 47c97cc to 5e1df0d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 10, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

148dad2src/sage/geometry/polyhedron/base.py: Add missing # optional - sage.rings.number_field
5e1df0dsrc/doc/en/thematic_tutorials/geometry/polyhedra_tutorial.rst: Add missing # optional - sage.rings.number_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2021

Changed commit from 5e1df0d to 44f15a0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

44f15a0Merge tag '9.5.beta6' into t/32846/sage_geometry_polyhedron__more___optional

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2021

Changed commit from 44f15a0 to 38ff15b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

38ff15bsrc/sage/geometry/polyhedron/base.py: Add missing sage.rings.number_field

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2021

Changed commit from 38ff15b to f2d72d3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 16, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

f2d72d3src/sage/geometry/polyhedron/parent.py: Remove unneeded import

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 16, 2021

Changed dependencies from #32776, #32732 to #32776, #32732, #32174

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Changed commit from f2d72d3 to 51ccab2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

7a81ba8move lattice point methods to Polyhedron_base2
10dd56dremove unused import
6a15f92move combinatorics to Polyhedron_base3
f7d87e2fix copy/paste-typo
6160076Merge branch 'u/gh-kliem/polyhedron_base3' of git://trac.sagemath.org/sage into u/gh-kliem/polyhedron_base4-new
ff8c7efmove methods relying on sage.graphs to Polyhedron_base4
51ccab2Merge #32889

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2021

Changed dependencies from #32776, #32732, #32174 to #32776, #32732, #32174, #32889

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 21, 2021

comment:16

messed up the merge

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Changed commit from 51ccab2 to 1c028c7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 21, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1c028c7Merge #32889

@kliem
Copy link
Contributor

kliem commented Dec 7, 2021

comment:19

LGTM.

@kliem
Copy link
Contributor

kliem commented Dec 7, 2021

Reviewer: Jonathan Kliem

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 8, 2021

comment:20

Thanks!

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Jan 10, 2022
@vbraun
Copy link
Member

vbraun commented Jan 31, 2022

Changed branch from u/mkoeppe/sage_geometry_polyhedron__more___optional to 1c028c7

@vbraun vbraun closed this as completed in 6008371 Jan 31, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32846
fb95488
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32846
62a7fa1
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32846
7b652b1
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32846
87d2c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.6
Development

No branches or pull requests
3 participants
@vbraun @mkoeppe @kliem