Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage-download-file: Limit number of mirrors contacted #34411

Closed
mkoeppe opened this issue Aug 23, 2022 · 3 comments · Fixed by #36565
Closed

sage-download-file: Limit number of mirrors contacted #34411

mkoeppe opened this issue Aug 23, 2022 · 3 comments · Fixed by #36565
Labels
c: build p: major / 3 t: enhancement wishlist item
Milestone
sage-10.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2022

In particular when --enable-download-from-upstream-url is in use.

CC: @jhpalmieri @dimpase @vbraun @williamstein

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/34411
@mkoeppe mkoeppe added this to the sage-9.7 milestone Aug 23, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 23, 2022

comment:1

https://github.com/sagemath/sage-prod/blob/develop/build/sage_bootstrap/download/mirror_list.py#L203 falls back to the server http://sagepad.org/

Who runs this server? Is this fallback still needed?

This server is not mentioned in https://trac.sagemath.org/wiki/Infrastructure

@DaveWitteMorris
Copy link
Member

comment:2

Sagepad seems to belong to Volker, so I would guess that this is his server, and I hope he can tell you whether it is obsolete. See
https://www.openhub.net/p/sagepad and https://github.com/vbraun/sagepad

@dimpase
Copy link
Member

dimpase commented Aug 23, 2022

comment:3

it seems that sagepad project has not been touched for 10 years. The server just gives a default Centos web server page, nothing there it seems.

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
vbraun pushed a commit to vbraun/sage that referenced this issue Nov 1, 2023
8f4a406 
sagemathgh-36565: Limit wait for slow mirrors
    
Using a timeout of 1 second unconditionally, stopping when 5 good
mirrors (300ms ping) are found

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Fixes sagemath#34411
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36565
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this issue Nov 2, 2023
964b9f9 
sagemathgh-36565: Limit wait for slow mirrors
    
Using a timeout of 1 second unconditionally, stopping when 5 good
mirrors (300ms ping) are found

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Fixes sagemath#34411
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36565
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
@vbraun vbraun closed this as completed in e6c9662 Nov 5, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement wishlist item
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging a pull request may close this issue.

Limit wait for slow mirrors mkoeppe/sage
3 participants
@dimpase @mkoeppe @DaveWitteMorris