Modularization fixes for imports of number fields #35283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 13, 2023 15:20
… keyword arg to all constructors
…ation' to super __init__
…plementation_repr
…eld_generic) outside of sage.rings.number_field
added 9 commits
March 14, 2023 00:14
…ort is_NumberField' | xargs sed -E -i.bak 's/is_NumberField\(([A-Za-z_]*(\(\))?)\)/isinstance(\1, NumberField)/;s/base import is_NumberField/base import NumberField/'
…te is_NumberField
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35283 +/- ##
===========================================
- Coverage 88.62% 88.61% -0.01%
===========================================
Files 2148 2148
Lines 398855 398860 +5
===========================================
- Hits 353480 353445 -35
- Misses 45375 45415 +40
... and 24 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
mezzarobba
approved these changes
Mar 15, 2023
|
Thanks for reviewing! |
added 2 commits
March 15, 2023 18:36
…nitefield' into numberfield_abc_imports
|
Documentation preview for this PR is ready! 🎉 |
mezzarobba
approved these changes
Mar 20, 2023
|
Thanks! |
|
Merge conflict |
SageMath version 10.0.beta6, Release Date: 2023-03-26
|
wait for the next beta |
|
Merged #35277 to resolve the merge conflict |
vbraun
pushed a commit
that referenced
this pull request
Apr 23, 2023
gh-35389: `sage.rings.finite_rings.residue_field`: Modularization fixes <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description Splitting out the implementations that depend on libraries NTL, PARI, Givaro to separate libraries. Marking doctests `# optional`. <!-- Describe your changes here in detail. --> This is part of: - #29705 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35283 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35389 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Using the ABC
sage.rings.number_field.number_field_base.NumberFieldDeprecating
is_NumberField.Part of:
📝 Checklist
⌛ Dependencies
sage.rings.polynomial.polynomial_ring[_constructor]: Handle missing implementation modules #35277