-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt the “time window-based” policy for support of Python versions from Spec-0 #35403
Conversation
In case you didn't see it - https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/x3qOdPB5BQAJ |
No, I've seen your comments. But what you propose essentially comes down to NEP29 + half a year or so, which just feels random. Also your work on the modularization is helping to promote that sage is used more actively in other python packages, so it gets more and more important to sync with the community standards. |
Tobias, I'm not "proposing" it. I'm describing our actual practice.
You don't need to explain this to me; but it has not happened yet. |
our actual practice is not ideal, on many fronts. |
General comments like this can hardly be a useful contribution to this discussion. |
no, you are declining to proceed with this PR on the same kind of grounds as my comment is based upon. |
Re-read https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/x3qOdPB5BQAJ; it has a detailed discussion, which cannot be dismissed by generalities. If you want to discuss -- then discuss, don't dismiss. |
you can reread my comment in that link, too. I don't understand why Sage must be trailing behind a number of its upstream components. |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
Well, I have explained that it does not. No package relevant for Sage has already dropped Python 3.8 in a released version or will before July. |
By the way, the numpy update to latest is waiting for review in #35081. |
Scipy is definitely dropping 3.8 soon, and they say they do follow NEP 29. Are we following NEP 29, or not? |
I explained the specifics in https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU/m/x3qOdPB5BQAJ |
No, we don't have this policy. The present PR (based on the Trac ticket that I opened in 2020, #30384), proposes to change that. |
In order to bring this back onto a good discussion platform, let me summarize your arguments for not adopting NEP 29:
Is this correct so far @mkoeppe? Did I miss an argument or misunderstood you? My response to these points is:
Finally, what makes sage so fundamentally different to scipy that its users should expect sage to support python versions released in the last 48 months, while scipy users are totally fine with support for releases in the last 42 months? Especially given that its very easy to install a new python version (pyenv, conda, ...). From experience, its definitely easier than installing sage itself ;-). In general, we have two competing view points:
Obviously, there is no objective line where these competing wishes are perfectly balanced. But I think its usually a good idea to align with established policies in the field in such cases, and NEP29 is the defacto most popular one. |
That's really far fetched. Our users have never asked us anything like that. |
I've already responded to this – yes, I'm aware of it; yes, making (portions of) the Sage library suitable as upstream for other packages is very much the point of the modularization; but no, it is not relevant yet. |
This is getting dialectical. |
What about seeing this as an experiment: we follow NEP29 for this release (i.e. drop python 3.8 support), and if there is a huge backslash by the community we change it to NEP29 + half a year? |
Yes, you made this point already. But dismissing something as not relevant without giving reasons is neither constructive nor helpful. |
Please, Tobias, that's inappropriate. I have already explained the reason. It's irrelevant now (for 10.0) because the modularization has not happened yet, so there's no real benefit; only an imaginary benefit. |
Not interested. |
there are obvious benefits in becoming a community member. Saying that historically Sage was not a member does not mean it has to continue to be so, and if you disagree, you can either call a vote on it, or just fork Sage and be your own boss. |
Documentation preview for this PR (built with commit 23d5360; changes) is ready! 🎉 |
NEP 29 is now superseded by https://scientific-python.org/specs/spec-0000/ so at least that needs updating
|
For this one, we had started a longer discussion on sage-devel. This needs to be resolved by bringing this back to sage-devel, definitely not by just merging a PR. |
I'd rather delegate the task of deciding this to @vbraun Discussions on any topic Matthias has an opinion deviating from other's people opinions lead to a riot lately. |
Thanks a lot for these suggestions! I've now changed this PR to use Spec-0 and referred to Spec-0 for the specific dates. |
sagemathgh-35403: Adopt the “time window-based” policy for support of Python versions from Spec-0 <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description Add a short paragraph to the developer guide explaining the Python support schedule. Previously discussed in sagemath#30384 and on the [mailing list](https://groups.google.com/g/sage-devel/c/j1cwbTU8aOU). Closes sagemath#30384. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35403 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
📚 Description
Add a short paragraph to the developer guide explaining the Python support schedule. Previously discussed in #30384 and on the mailing list. Closes #30384.
📝 Checklist
⌛ Dependencies