-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.matroids
: Update # needs
, modularization fixes for imports
#35919
Conversation
…dules' --only-tags --probe=sage.rings.finite_rings --overwrite src/sage/matroids/*.py
…dules' --only-tags --probe=sage.rings.finite_rings --overwrite src/sage/matroids/*.{py,pyx}
…aphs[modules]' --only-tags --probe=sage.rings.finite_rings --overwrite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much lighter this way, in particular with the use of block statements like sage: # needs sage.graphs
.
sage: M4 = CircuitClosuresMatroid(groundset='abcdefg', | ||
....: circuit_closures={3: ['abcdefg'], 2: ['beg', 'cdb', 'cfg', | ||
....: 'ace', 'fed', 'gad', 'fab']}).dual() | ||
sage: M1.dual() != M2 # indirect doctest # optional - sage.rings.finite_rings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing the indirect doctest
statement ? Isn't it useful ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this mistake. I've restored it in 4d11269
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you! |
Documentation preview for this PR (built with commit 007f6ae; changes) is ready! 🎉 |
📚 Description
# optional
are removed because small prime finite fields no longer need to be marked# optional/needs sage.rings.finite_rings
since Integer.{perfect_power,is_prime_power,is_irreducible}: Handle easy cases without PARI #35847# optional
are replaced by codeblock-scoped# needs
tags# optional
with standard features are replaced by# needs
This is:
sage -fixdoctests
from Add style guide / reference for# optional - sage....
doctest tags, extendsage -t
andsage -fixdoctests
for modularization tasks #35749📝 Checklist
⌛ Dependencies