Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.matroids: Update # needs, modularization fixes for imports #35919

Merged
merged 11 commits into from
Jul 20, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jul 8, 2023

📚 Description

This is:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jul 9, 2023
@mkoeppe mkoeppe requested a review from dcoudert July 10, 2023 17:20
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much lighter this way, in particular with the use of block statements like sage: # needs sage.graphs.

sage: M4 = CircuitClosuresMatroid(groundset='abcdefg',
....: circuit_closures={3: ['abcdefg'], 2: ['beg', 'cdb', 'cfg',
....: 'ace', 'fed', 'gad', 'fab']}).dual()
sage: M1.dual() != M2 # indirect doctest # optional - sage.rings.finite_rings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the indirect doctest statement ? Isn't it useful ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this mistake. I've restored it in 4d11269

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 12, 2023

Thank you!

@github-actions
Copy link

Documentation preview for this PR (built with commit 007f6ae; changes) is ready! 🎉

@vbraun vbraun merged commit e0c51e5 into sagemath:develop Jul 20, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants