Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/dist.yml: Create release on release tag #36438

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Oct 10, 2023

We extend our workflow dist.yml, which gets run on every release tag, to do the following:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 8ee6738; changes) is ready! 🎉

@dimpase
Copy link
Member

dimpase commented Oct 10, 2023

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 10, 2023

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 15, 2023
sagemathgh-36438: .github/workflows/dist.yml: Create release on release tag
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
We extend our workflow dist.yml, which gets run on every release tag, to
do the following:
- For stable releases (no beta, no rc), when run on sagemath/sage, it
automatically creates a Release. (This saves a few clicks by maintainers
on each release.)
- It uploads the sdist (the 1.2GB file which contains upstream tarballs
for all standard packages) as a Release Asset.
- It uploads the upstream tarballs as Release Assets. They will be used
by the Sage distribution after sagemath#36435
Example of the run:
https://github.com/mkoeppe/sage/actions/runs/6464035205/job/17549159925
(where I changed the condition from sagemath/sage to mkoeppe/sage),
leading to the example release
https://github.com/mkoeppe/sage/releases/tag/10.2.beta007

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36438
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 17, 2023
sagemathgh-36438: .github/workflows/dist.yml: Create release on release tag
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
We extend our workflow dist.yml, which gets run on every release tag, to
do the following:
- For stable releases (no beta, no rc), when run on sagemath/sage, it
automatically creates a Release. (This saves a few clicks by maintainers
on each release.)
- It uploads the sdist (the 1.2GB file which contains upstream tarballs
for all standard packages) as a Release Asset.
- It uploads the upstream tarballs as Release Assets. They will be used
by the Sage distribution after sagemath#36435
Example of the run:
https://github.com/mkoeppe/sage/actions/runs/6464035205/job/17549159925
(where I changed the condition from sagemath/sage to mkoeppe/sage),
leading to the example release
https://github.com/mkoeppe/sage/releases/tag/10.2.beta007

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36438
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit 0cdf0b3 into sagemath:develop Oct 21, 2023
@mkoeppe mkoeppe added this to the sage-10.2 milestone Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants