Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_FreeAlgebra, is_QuaternionAlgebra, is_SymmetricFunctionAlgebra #37896

Merged
merged 3 commits into from
May 12, 2024
Merged

Deprecate is_FreeAlgebra, is_QuaternionAlgebra, is_SymmetricFunctionAlgebra #37896

merged 3 commits into from
May 12, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 29, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe force-pushed the is_Algebra_deprecations branch from 7d885e6 to d120bce Compare April 29, 2024 04:41
@mkoeppe mkoeppe self-assigned this Apr 29, 2024
@mkoeppe mkoeppe changed the title Deprecate is_SymmetricFunctionAlgebra Deprecate is_FreeAlgebra, is_QuaternionAlgebra, is_SymmetricFunctionAlgebra Apr 29, 2024
@mkoeppe mkoeppe marked this pull request as ready for review April 29, 2024 04:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 4a3ffbd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although I am mildly hesitant with the is_FreeAlgebra because it is testing multiple classes).

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2024

Thanks! Of course we can later follow up with an ABC for FreeAlgebra, but I didn't want to mix a discussion on naming or API in this PR.

@mkoeppe mkoeppe force-pushed the is_Algebra_deprecations branch from d120bce to 4a3ffbd Compare May 8, 2024 01:28
kwankyu
kwankyu approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2024

Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
3450d9f 
sagemathgh-37896: Deprecate `is_FreeAlgebra`, `is_QuaternionAlgebra`, `is_SymmetricFunctionAlgebra`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#32738

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37896
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
32fe2a8 
sagemathgh-37896: Deprecate `is_FreeAlgebra`, `is_QuaternionAlgebra`, `is_SymmetricFunctionAlgebra`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Fixes sagemath#32738

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37896
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Travis Scrimshaw
@vbraun vbraun merged commit 9e2d10a into sagemath:develop May 12, 2024
15 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
@mkoeppe mkoeppe deleted the is_Algebra_deprecations branch May 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@tscrim tscrim tscrim approved these changes

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

Deprecate is_Algebra, is_CommutativeAlgebra, is_FreeAlgebra, is_QuaternionAlgebra, is_SymmetricFunctionAlgebra
4 participants
@mkoeppe @kwankyu @tscrim @vbraun