Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.plot, sage.repl: Modularization fixes (imports), # needs #38181

Merged
merged 4 commits into from
Jun 22, 2024
Merged

sage.plot, sage.repl: Modularization fixes (imports), # needs #38181

merged 4 commits into from
Jun 22, 2024
+66 −48

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 9, 2024 •
edited
Loading

Also removing a use of SR, when testing for Expression is good enough.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Sorry, something went wrong.

@mkoeppe mkoeppe self-assigned this Jun 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 5dfa06c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 11, 2024 •
edited
Loading

Otherwise lgtm.

Matthias Koeppe added 3 commits June 10, 2024 21:33
@mkoeppe
src/sage/plot/hyperbolic_regular_polygon.py: Sort imports, replace .a…
c9f1823 
…ll import, separate out lazy_import
@mkoeppe
src/sage/plot/plot3d/plot3d.py: Sort imports, replace relative import…
9dbe263 
…s, separate out lazy_import
@mkoeppe
src/sage/repl/ipython_kernel/interact.py: Sort imports, replace relat…
Loading
Loading status checks…
5dfa06c 
…ive imports, remove duplicate import, separate out lazy_import
kwankyu
kwankyu approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 11, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
4c08eb9 
sagemathgh-38181: `sage.plot`, `sage.repl`: Modularization fixes (imports), `# needs`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Also removing a use of `SR`, when testing for `Expression` is good
enough.

- Cherry-picked from sagemath#35095.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38181
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
a689e7d 
sagemathgh-38181: `sage.plot`, `sage.repl`: Modularization fixes (imports), `# needs`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Also removing a use of `SR`, when testing for `Expression` is good
enough.

- Cherry-picked from sagemath#35095.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38181
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit e57b899 into sagemath:develop Jun 22, 2024
22 of 23 checks passed
@mkoeppe mkoeppe deleted the sage_plot_repl_modularization branch June 22, 2024 20:23
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu

Assignees

@mkoeppe mkoeppe

Labels
c: graphics c: user interface t: refactoring v: small
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkoeppe @kwankyu @vbraun