fix the behavior for immutable graphs in methods related to isomorphisms in sage/graphs/generic_graph.py
#39296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit abcb366; changes) is ready! 🎉 |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 10, 2025
sagemathgh-39297: more care about parameter `immutable` in `sage/graphs/generic_graph.py` Following sagemath#39280, sagemath#39285, sagemath#39287, sagemath#39296 and discussions in sagemath#39177, we add parameter immutable to methods in `sage/graphs/generic_graph.py`: - `longest_cycle` - `longest_path` - `hamiltonian_path` - and add tests in `cycle_basis` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39297 Reported by: David Coudert Reviewer(s): Kwankyu Lee
|
Thank you ! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 19, 2025
sagemathgh-39296: fix the behavior for immutable graphs in methods related to isomorphisms in `sage/graphs/generic_graph.py` Following sagemath#39280 and discussions in sagemath#39177, we add parameter `immutable` to methods related to graph isomorphisms in `sage/graphs/generic_graph.py` and `bliss.pyx`: - `canonical_form` - `automorphism_group` - `is_isomorphic` - `graph_isom_equivalent_non_edge_labeled_graph` - and also `cayley_graph` We also fix the behavior of method `canonical_label` in `BipartiteGraph`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39296 Reported by: David Coudert Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #39280 and discussions in #39177, we add parameter
immutableto methods related to graph isomorphisms insage/graphs/generic_graph.pyandbliss.pyx:canonical_formautomorphism_groupis_isomorphicgraph_isom_equivalent_non_edge_labeled_graphcayley_graphWe also fix the behavior of method
canonical_labelinBipartiteGraph.📝 Checklist
⌛ Dependencies