Added option to return explicit polynomial in .in_subalgebra #39555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit d0845dd; changes) is ready! 🎉 |
tscrim
approved these changes
Feb 21, 2025
Co-authored-by: Travis Scrimshaw <[email protected]>
Co-authored-by: Travis Scrimshaw <[email protected]>
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 24, 2025
sagemathgh-39555: Added option to return explicit polynomial in .in_subalgebra <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#39225. Previously the function in_subalgebra in src/sage/rins/polynomial/multi_polynomial_libsingular.pyx returned True or False, depending on whether the polynomial was present in the provided subalgebra. When the parameter 'algorithm' was set to 'groebner' it would do this by generating a polynomial, but this polynomial would not be made available to the user. This function was enhanced by adding a key-word only argument 'certificate' to the function which defaults to False. When the value provided for this argument evaluates to False the function behaves as before. When the value provided evaluates to True and the Groebner algorithm is used the function returns the polynomial generated by the algorithm when it would have otherwise returned True, and returns None when it would have otherwise returned False. Additionally, if the value provided for the 'certificate' argument is a string which evaluates to True then that string will be used to name the variables in the generated polynomial. The existing example for this function has been modified to test this new functionality. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39555 Reported by: Caleb Van't Land Reviewer(s): Caleb Van't Land, Travis Scrimshaw
|
Oops, already merged. This part of the documentation is misformatted because of a missing space before
|
|
Easy enough to fix on a followup PR. |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39623: Fix spacing for documentation Partially discussed in sagemath#39555. Meanwhile I find a few more. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39623 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39623: Fix spacing for documentation Partially discussed in sagemath#39555. Meanwhile I find a few more. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39623 Reported by: user202729 Reviewer(s): Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39225.
Previously the function in_subalgebra in src/sage/rins/polynomial/multi_polynomial_libsingular.pyx returned True or False, depending on whether the polynomial was present in the provided subalgebra. When the parameter 'algorithm' was set to 'groebner' it would do this by generating a polynomial, but this polynomial would not be made available to the user.
This function was enhanced by adding a key-word only argument 'certificate' to the function which defaults to False. When the value provided for this argument evaluates to False the function behaves as before. When the value provided evaluates to True and the Groebner algorithm is used the function returns the polynomial generated by the algorithm when it would have otherwise returned True, and returns None when it would have otherwise returned False.
Additionally, if the value provided for the 'certificate' argument is a string which evaluates to True then that string will be used to name the variables in the generated polynomial.
The existing example for this function has been modified to test this new functionality.
📝 Checklist
⌛ Dependencies