-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson: Remove unused build dependencies ppl and fplll #39562
Meson: Remove unused build dependencies ppl and fplll #39562
Conversation
Documentation preview for this PR (built with commit 8ab64d8; changes) is ready! 🎉 |
What's different about ppl, do we use it outside of pplpy? |
I'm not sure. There is something called a |
I don't think there's any required executable. All that is needed at runtime is |
PPL on Gentoo only installs two executables, For libppl, I've done a |
Thanks for checking! I've now completely removed ppl as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm as sure as I'll ever be, let's see what happens.
sagemathgh-39562: Meson: Remove unused build dependencies ppl and fplll <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Remove ppl and fplll as (build) dependencies according to sagemath#39548 (comment) since they are only used via their python wrappers. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39562 Reported by: Tobias Diez Reviewer(s): Gonzalo Tornaría, Michael Orlitzky
Remove ppl and fplll as (build) dependencies according to #39548 (comment) since they are only used via their python wrappers.
📝 Checklist
⌛ Dependencies