Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson: Remove unused build dependencies ppl and fplll #39562

Merged
merged 3 commits into from
Mar 9, 2025

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Feb 21, 2025

Remove ppl and fplll as (build) dependencies according to #39548 (comment) since they are only used via their python wrappers.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 8ab64d8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@orlitzky
Copy link
Contributor

What's different about ppl, do we use it outside of pplpy?

@tobiasdiez
Copy link
Contributor Author

tobiasdiez commented Feb 28, 2025

What's different about ppl, do we use it outside of pplpy?

I'm not sure. There is something called a MixedIntegerLinearProgram with argument ppl whose name at least suggests that it might call some executable. Do you know if we directly call/access ppl or is it only via pplpy?

@tornaria
Copy link
Contributor

What's different about ppl, do we use it outside of pplpy?

I'm not sure. There is something called a MixedIntegerLinearProgram with argument ppl whose name at least suggests that it might call some executable. Do you know if we directly call/access ppl or is it only via pplpy?

I don't think there's any required executable. All that is needed at runtime is pplpy and its implied dependencies (i.e., the shared library libppl.so.14). Neither is necessary at build time.

@orlitzky
Copy link
Contributor

orlitzky commented Mar 1, 2025

PPL on Gentoo only installs two executables, /usr/bin/ppl-config and /usr/bin/ppl_pips. The first one is a pkg-config replacement, and the second doesn't turn up in grep, so I'm pretty confident that we don't use either at runtime.

For libppl, I've done a find ... xargs objdump -p on the sage install and nothing turned up. 🤷

@tobiasdiez
Copy link
Contributor Author

Thanks for checking! I've now completely removed ppl as well.

Copy link
Contributor

@orlitzky orlitzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm as sure as I'll ever be, let's see what happens.

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 9, 2025
sagemathgh-39562: Meson: Remove unused build dependencies ppl and fplll
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Remove ppl and fplll as (build) dependencies according to
sagemath#39548 (comment)
since they are only used via their python wrappers.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39562
Reported by: Tobias Diez
Reviewer(s): Gonzalo Tornaría, Michael Orlitzky
@vbraun vbraun merged commit 7851798 into sagemath:develop Mar 9, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants